Serial mkfs #1169
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -337,3 +337,17 @@ func (mounter *CSIProxyMounterV1) MountSensitiveWithoutSystemd(source string, ta | |
| func (mounter *CSIProxyMounterV1) MountSensitiveWithoutSystemdWithMountFlags(source string, target string, fstype string, options []string, sensitiveOptions []string, mountFlags []string) error { | ||
| return errors.New("MountSensitiveWithoutSystemd is not implemented") | ||
| } | ||
|
|
||
| // CanSafelySkipMountPointCheck always returns false on Windows. | ||
|
There was a problem hiding this comment. @msau42 I had to add this because of two breaking changes that updated the interface. Could you confirm that it's safe to use the upstream implementation? https://github.com/kubernetes/mount-utils/blob/master/mount_windows.go#L247-L259 There was a problem hiding this comment. Until we switch to Windows host process #1071, we may not be able to do many mount operations directly. @mauriciopoppe can you confirm? There was a problem hiding this comment. This file only uses the following exported properties from k8s.io/mount-utils:
None of these paths use these two methods. I believe it's safe to use the upstream implementation, in Windows we're not doing mount directly yet because #1071 isn't merged, if #1071 is merged these two paths won't be used still. lgtm |
||
| func (mounter *CSIProxyMounterV1) CanSafelySkipMountPointCheck() bool { | ||
| return false | ||
| } | ||
|
|
||
| // IsMountPoint returns true if a directory is a mountpoint. | ||
| func (mounter *CSIProxyMounterV1) IsMountPoint(file string) (bool, error) { | ||
| isNotMnt, err := mounter.IsLikelyNotMountPoint(file) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| return !isNotMnt, nil | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be able to get rid of the replace statement if you put 0.24.1 here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already tried that and wrestled with this for a while:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that means that some of our dependencies need us to specify the version via replace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like
v11.0.1-0.20190805182717-6502b5e7b1b5+incompatibleis arbitrary and doesn't show up in our go.sum file. Pulling the latest version is just a way forgo mod tidyto satisfy the require directive syntax.