-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the supported kubernetes versions #755
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @ccfishk! |
Hi @ccfishk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this @ccfishk! This mostly LGTM, just a couple nits. Looks like you'll also need to sign the CLA before this can get in.
/kind documentation |
Co-authored-by: Rob Scott <[email protected]>
Co-authored-by: Rob Scott <[email protected]>
@hbagdi kindly point how should I proceed to resolve this. |
I already signed the document successfully.
|
"I signed it" |
/check-cla |
Think the check fails because my kong email received the "HelloSign", where my github commit email is personal account. |
@ccfishk Yep, I think that should fix it. |
/ok-to-test |
/check-cla |
"I signed it". And change the email account to primary email account. |
@ccfishk You have created the commits on this PR with two separate email addresses:
I'd recommend squashing these commits and then using the same email address you used to sign the CLA to use in the commit. |
To verify the fix, I opened a new PR #769 pushed using the same email where receiving the "HelloSign" CLA confirmation. |
/check-cla |
/lgtm Congrats on getting the CLA stuff sorted out! |
Thanks @ccfishk! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccfishk, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Clarify which Kubernetes versions are supported
Which issue(s) this PR fixes:
Fix #737
Does this PR introduce a user-facing change?: