Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the supported kubernetes versions #755

Merged
merged 5 commits into from
Aug 16, 2021
Merged

Document the supported kubernetes versions #755

merged 5 commits into from
Aug 16, 2021

Conversation

ccfishk
Copy link
Contributor

@ccfishk ccfishk commented Aug 9, 2021

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Clarify which Kubernetes versions are supported

Which issue(s) this PR fixes:

Fix #737

Does this PR introduce a user-facing change?:


@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 9, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @ccfishk!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ccfishk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from hbagdi and robscott August 9, 2021 14:08
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this @ccfishk! This mostly LGTM, just a couple nits. Looks like you'll also need to sign the CLA before this can get in.

site-src/v1alpha2/faq.md Outdated Show resolved Hide resolved
site-src/v1alpha2/faq.md Outdated Show resolved Hide resolved
@robscott
Copy link
Member

robscott commented Aug 9, 2021

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 9, 2021
@ccfishk
Copy link
Contributor Author

ccfishk commented Aug 9, 2021

Welcome @ccfishk!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@hbagdi kindly point how should I proceed to resolve this.

@ccfishk
Copy link
Contributor Author

ccfishk commented Aug 10, 2021

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

I already signed the document successfully.

You have successfully signed your document  

@ccfishk
Copy link
Contributor Author

ccfishk commented Aug 10, 2021

"I signed it"

@robscott
Copy link
Member

/check-cla

@ccfishk
Copy link
Contributor Author

ccfishk commented Aug 10, 2021

/check-cla

Think the check fails because my kong email received the "HelloSign", where my github commit email is personal account.
assuming following https://github.com/kubernetes/community/blob/master/CLA.md#4-ensure-your-github-e-mail-address-matches-address-used-to-sign-cla should fix this.
Or, any other suggestion here ?

@robscott
Copy link
Member

@ccfishk Yep, I think that should fix it.

@jpeach
Copy link
Contributor

jpeach commented Aug 11, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2021
@jpeach
Copy link
Contributor

jpeach commented Aug 11, 2021

/check-cla

@ccfishk
Copy link
Contributor Author

ccfishk commented Aug 11, 2021

"I signed it". And change the email account to primary email account.

@hbagdi
Copy link
Contributor

hbagdi commented Aug 11, 2021

@ccfishk You have created the commits on this PR with two separate email addresses:

commit 03197d581ff9ded667acfd58d9004a5fd8c1f5db (HEAD -> 755, pr/755)
Author: ccfishk <[email protected]>
Date:   Tue Aug 10 17:51:22 2021 -0700

    fix email address

commit 28353e4a25a218631544a979131533a709619ab1
Author: ccfishk <[email protected]>
Date:   Mon Aug 9 15:37:46 2021 -0700

    format restrict each line less than 80 characters.

commit 4e78d449085f09081dbe96b3c384777d4f52ceb6
Author: Jimin <[email protected]>
Date:   Mon Aug 9 15:34:09 2021 -0700

    Update site-src/v1alpha2/faq.md
    
    Co-authored-by: Rob Scott <[email protected]>

commit 27840814f3b7d04819c38ec16dcca51f20986c69
Author: Jimin <[email protected]>
Date:   Mon Aug 9 15:30:19 2021 -0700

    Update site-src/v1alpha2/faq.md
    
    Co-authored-by: Rob Scott <[email protected]>

commit a74bfdeb5a66ada7c35f7d2412e56b1408b7adb4
Author: ccfishk <[email protected]>
Date:   Mon Aug 9 07:04:28 2021 -0700

    Fix kubernetes version support

I'd recommend squashing these commits and then using the same email address you used to sign the CLA to use in the commit.
Using the same email address as the CLA will be required for any subsequent contribution as well.

@ccfishk
Copy link
Contributor Author

ccfishk commented Aug 12, 2021

@ccfishk You have created the commits on this PR with two separate email addresses:

commit 03197d581ff9ded667acfd58d9004a5fd8c1f5db (HEAD -> 755, pr/755)
Author: ccfishk <[email protected]>
Date:   Tue Aug 10 17:51:22 2021 -0700

    fix email address

commit 28353e4a25a218631544a979131533a709619ab1
Author: ccfishk <[email protected]>
Date:   Mon Aug 9 15:37:46 2021 -0700

    format restrict each line less than 80 characters.

commit 4e78d449085f09081dbe96b3c384777d4f52ceb6
Author: Jimin <[email protected]>
Date:   Mon Aug 9 15:34:09 2021 -0700

    Update site-src/v1alpha2/faq.md
    
    Co-authored-by: Rob Scott <[email protected]>

commit 27840814f3b7d04819c38ec16dcca51f20986c69
Author: Jimin <[email protected]>
Date:   Mon Aug 9 15:30:19 2021 -0700

    Update site-src/v1alpha2/faq.md
    
    Co-authored-by: Rob Scott <[email protected]>

commit a74bfdeb5a66ada7c35f7d2412e56b1408b7adb4
Author: ccfishk <[email protected]>
Date:   Mon Aug 9 07:04:28 2021 -0700

    Fix kubernetes version support

I'd recommend squashing these commits and then using the same email address you used to sign the CLA to use in the commit.
Using the same email address as the CLA will be required for any subsequent contribution as well.

To verify the fix, I opened a new PR #769 pushed using the same email where receiving the "HelloSign" CLA confirmation.

@ccfishk
Copy link
Contributor Author

ccfishk commented Aug 13, 2021

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 13, 2021
@youngnick
Copy link
Contributor

/lgtm

Congrats on getting the CLA stuff sorted out!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2021
@robscott robscott added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 16, 2021
@robscott
Copy link
Member

Thanks @ccfishk!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccfishk, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit b8b7f20 into kubernetes-sigs:master Aug 16, 2021
@ccfishk ccfishk deleted the k8s-version branch August 16, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the supported Kubernetes versions
7 participants