Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional API Testing for GEP-3171 #3300

Closed
wants to merge 82 commits into from

Conversation

jakebennert
Copy link
Contributor

What type of PR is this?
/kind test

What this PR does / why we need it:
This PR adds additional tests for API changes made in #3283.

Does this PR introduce a user-facing change?:

NONE

jakebennert and others added 30 commits June 29, 2024 17:29
Also updated field descriptions to match the validation. Removed the default value for Percent.
@k8s-ci-robot k8s-ci-robot requested a review from robscott August 27, 2024 17:49
@k8s-ci-robot
Copy link
Contributor

Hi @jakebennert. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2024
@robscott
Copy link
Member

Thanks @jakebennert!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2024
@kflynn
Copy link
Contributor

kflynn commented Aug 27, 2024

Whoa, this is a lot of commits for "add some tests". 😂 @jakebennert, can you verify that this is set up correctly? 🙂

@jakebennert
Copy link
Contributor Author

Whoa, this is a lot of commits for "add some tests". 😂 @jakebennert, can you verify that this is set up correctly? 🙂

Yeah sorry - I'm a little new to github. I think I need to do some rebasing to get rid of the old commits that aren't relevant.

@jakebennert jakebennert changed the base branch from main to release-1.1 August 28, 2024 06:29
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2024
@jakebennert jakebennert changed the base branch from release-1.1 to main August 28, 2024 06:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 28, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 28, 2024

@jakebennert: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-verify 4361500 link true /test pull-gateway-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 28, 2024
@jakebennert
Copy link
Contributor Author

Ok I've fixed my working branch and gotten rid of all those previous unrelated commits, but I did have to create a new PR. If we could scoot our way over to #3302, we can hopefully get this show on the road. Sorry for the confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants