-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional API Testing for GEP-3171 #3300
Conversation
Co-authored-by: Rob Scott <[email protected]>
Co-authored-by: Rob Scott <[email protected]>
Co-authored-by: Rob Scott <[email protected]>
Also updated field descriptions to match the validation. Removed the default value for Percent.
Co-authored-by: Rob Scott <[email protected]>
Co-authored-by: Rob Scott <[email protected]>
Hi @jakebennert. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks @jakebennert! /ok-to-test |
Whoa, this is a lot of commits for "add some tests". 😂 @jakebennert, can you verify that this is set up correctly? 🙂 |
Yeah sorry - I'm a little new to github. I think I need to do some rebasing to get rid of the old commits that aren't relevant. |
@jakebennert: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Ok I've fixed my working branch and gotten rid of all those previous unrelated commits, but I did have to create a new PR. If we could scoot our way over to #3302, we can hopefully get this show on the road. Sorry for the confusion! |
What type of PR is this?
/kind test
What this PR does / why we need it:
This PR adds additional tests for API changes made in #3283.
Does this PR introduce a user-facing change?: