Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionPersistence pointer field should have omitempty tag #3059

Merged
merged 1 commit into from
May 6, 2024
Merged

SessionPersistence pointer field should have omitempty tag #3059

merged 1 commit into from
May 6, 2024

Conversation

sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented May 6, 2024 •
edited
Loading

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

SessionPersistence pointer field should have an omitempty tag, this is the idiomatic way to tag such pointer fields and matches other such instances in the golang API

Not a huge issue per se, but when using the updated gateway-api v1.1.0 go module with an API server that has v1.0.0 CRDs, avoids warnings like:

time="2024-05-06T16:19:19Z" level=info msg="unknown field \"spec.rules[0].sessionPersistence\"" logger=KubeAPIWarningLogger

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2024
@k8s-ci-robot k8s-ci-robot requested review from robscott and youngnick May 6, 2024 17:53
@robscott
Copy link
Member

robscott commented May 6, 2024

Thanks @sunjayBhatia!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 95d865e into kubernetes-sigs:main May 6, 2024
8 checks passed
@sunjayBhatia sunjayBhatia deleted the httproute-sessionpersistence-omitempty branch May 6, 2024 18:39
@arkodg arkodg mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunjayBhatia @robscott @k8s-ci-robot