Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTPRouteHTTPSListener unknown host test case #3045

Conversation

sunjayBhatia
Copy link
Member

What type of PR is this?

/kind bug
/kind test

/area conformance

What this PR does / why we need it:

While validating v1.1.0-rc1 with Contour, we are running into this test failing

The request to unknown-example.com never succeeds to get an HTTP response (the test expects a 404), since there is no Listener/certificate configured that will allow the gateway to terminate the TLS connection

See #3044

Which issue(s) this PR fixes:

Updates #3044 but does not close it

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/test area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 2, 2024
@k8s-ci-robot k8s-ci-robot requested review from mlavacca and Xunzhuo May 2, 2024 00:09
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2024
@robscott
Copy link
Member

robscott commented May 2, 2024

Thanks @sunjayBhatia!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2024
@sunjayBhatia
Copy link
Member Author

well @robscott now I'm reading the test over again, this might be totally fine and just a deficiency of Contour since the same-namespace-with-https-listener Gateway does have a TLS Listener without a hostname configured (and with a generic enough certificate) so presumably an implementation should be expected to accept a connection on it

@sunjayBhatia
Copy link
Member Author

I'm going to close this for now since I think this is probably correct actually, sorry for the confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants