-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance tests for HTTPRoute+Gateway HTTPS Listener #2824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test passes w/ contour 👍🏽
looks like the gateway in use same-namespace-with-https-listener
is only ever used otherwise in HTTPRouteRedirectPortAndScheme
which as you say is blocked from being generally part of core since it has other extended features required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, passes with Kuma
adding approvers adding reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Conformance reviewers/approvers - can I get review please @arkodg @mlavacca @LiorLieberman @Xunzhuo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
thanks !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arkodg, dprotaso, frankbu, michaelbeaumont, sunjayBhatia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sunjayBhatia @mlavacca can you add an |
/lgtm |
/lgtm |
CI is being weird - resetting it by re-opening the PR |
What type of PR is this?
/kind cleanup
/kind test
/area conformance
What this PR does / why we need it:
There's no 'Core' conformance tests that validates the combination of a HTTPRoute with a Gateway HTTPS Listener.
There are other tests but they're 'Extended' and behind various feature flags
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: