Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance tests for HTTPRoute+Gateway HTTPS Listener #2824

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Feb 27, 2024

What type of PR is this?
/kind cleanup
/kind test
/area conformance

What this PR does / why we need it:

There's no 'Core' conformance tests that validates the combination of a HTTPRoute with a Gateway HTTPS Listener.

There are other tests but they're 'Extended' and behind various feature flags

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/test area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 27, 2024
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test passes w/ contour 👍🏽

looks like the gateway in use same-namespace-with-https-listener is only ever used otherwise in HTTPRouteRedirectPortAndScheme which as you say is blocked from being generally part of core since it has other extended features required

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@dprotaso dprotaso changed the title Conformance tests for HTTPRoute+Gateway TLS Listener Conformance tests for HTTPRoute+Gateway HTTPS Listener Mar 5, 2024
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, passes with Kuma

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2024
@dprotaso
Copy link
Contributor Author

dprotaso commented Mar 7, 2024

adding approvers
/assign @arkodg @mlavacca @sunjayBhatia

adding reviewers
/cc @LiorLieberman @michaelbeaumont @Xunzhuo

@k8s-ci-robot k8s-ci-robot requested a review from Xunzhuo March 7, 2024 22:41
Copy link
Contributor

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dprotaso
Copy link
Contributor Author

dprotaso commented Apr 1, 2024

Conformance reviewers/approvers - can I get review please @arkodg @mlavacca @LiorLieberman @Xunzhuo

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

thanks !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, dprotaso, frankbu, michaelbeaumont, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Contributor Author

dprotaso commented Apr 5, 2024

@sunjayBhatia @mlavacca can you add an /lgtm

@sunjayBhatia
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@sunjayBhatia
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@dprotaso dprotaso closed this Apr 8, 2024
@dprotaso dprotaso reopened this Apr 8, 2024
@dprotaso
Copy link
Contributor Author

dprotaso commented Apr 8, 2024

CI is being weird - resetting it by re-opening the PR

@k8s-ci-robot k8s-ci-robot merged commit 1fc82ee into kubernetes-sigs:main Apr 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants