conformance: revert ver to v1beta1 for RefGrant #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReferenceGrant's version was moved to `v1` as a mistake in the conformance test YAML Relates to kubernetes-sigs#2486 Signed-off-by: Arko Dasgupta <[email protected]>
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arkodg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
🤦 Thanks @arkodg! Mind adding a release note block so we don't miss it in RC2 changelog? Once you do that, this should merge. /lgtm |
k8s-ci-robot
added
lgtm
6 tasks
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
Oct 26, 2023
Relates to kubernetes-sigs/gateway-api#2494 Fixes envoyproxy#2002 Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
added a commit
to envoyproxy/gateway
that referenced
this pull request
Oct 26, 2023
Relates to kubernetes-sigs/gateway-api#2494 Fixes #2002 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: zirain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReferenceGrant's version was moved to
v1as a mistake in the conformance test YAMLRelates to #2486
Does this PR introduce a user-facing change?: