Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BackendTLSPolicy cel tests #2491

Merged
merged 2 commits into from
Oct 20, 2023
Merged

BackendTLSPolicy cel tests #2491

merged 2 commits into from
Oct 20, 2023

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented Oct 17, 2023

What type of PR is this?

/kind test

What this PR does / why we need it:

Without it, it's awfully hard to ensure that the CEL we've written covers all the inputs we want to allow or prevent.

Which issue(s) this PR fixes:

Fixes #2473

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/test labels Oct 17, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 17, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @Ygnas!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Ygnas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 17, 2023
@robscott
Copy link
Member

Thanks @Ygnas!

/ok-to-test
/approve
/cc @candita

@k8s-ci-robot k8s-ci-robot requested a review from candita October 18, 2023 00:07
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
gauravkghildiyal
gauravkghildiyal reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@gauravkghildiyal gauravkghildiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @Ygnas !

config/crd/experimental/gateway.networking.k8s.io_backendtlspolicies.yaml Show resolved Hide resolved
pkg/test/cel/backendtlspolicy_test.go Outdated Show resolved Hide resolved
@Ygnas Ygnas force-pushed the backendtlspolicy-cel-tests branch from 2b2a8b9 to b3a6b7e Compare October 18, 2023 09:06
@Ygnas Ygnas force-pushed the backendtlspolicy-cel-tests branch from b3a6b7e to 5a94447 Compare October 18, 2023 09:38
@Ygnas Ygnas force-pushed the backendtlspolicy-cel-tests branch from 5a94447 to 91502f9 Compare October 18, 2023 11:47
@Ygnas
Copy link
Contributor Author

Ygnas commented Oct 18, 2023 •
edited
Loading

I'm not 100% sure if we should test //+kubebuilder:validation:MaxItems=8 for CACertRefs here, also, should we be testing LocalObjectReference in this context?

@gauravkghildiyal
Copy link
Member

@Ygnas The immediate intent is to just verify the two validations defined through +kubebuilder:validation:XValidation. So I think what we have now should be sufficient.

Thanks for taking this on.

LGTM (will defer approval to maintainers)

youngnick
youngnick reviewed Oct 20, 2023
View reviewed changes
apis/v1alpha2/backendtlspolicy_types.go
@@ -75,8 +75,8 @@ type BackendTLSPolicySpec struct {
}

// BackendTLSPolicyConfig contains backend TLS policy configuration.
// +kubebuilder:validation:XValidation:message="must not contain both CertRefs and WellKnownCACerts",rule="(has(self.caCertRefs) && size(self.caCertRefs) > 0 && has(self.wellKnownCACerts) && self.wellKnownCACerts != \"\")"
// +kubebuilder:validation:XValidation:message="must specify either CertRefs or WellKnownCACerts",rule="!(has(self.caCertRefs) && size(self.caCertRefs) > 0 || has(self.wellKnownCACerts) && self.wellKnownCACerts != \"\")"
// +kubebuilder:validation:XValidation:message="must not contain both CACertRefs and WellKnownCACerts",rule="!(has(self.caCertRefs) && size(self.caCertRefs) > 0 && has(self.wellKnownCACerts) && self.wellKnownCACerts != \"\")"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And there's a great example of why tests are important! Thanks @Ygnas.

@youngnick
Copy link
Contributor

Yes, I think that testing the max items or LocalObjectReference are not desirable here - there is a good chance that both of those will change soon anyway.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit cdc85ca into kubernetes-sigs:main Oct 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngnick youngnick youngnick left review comments

@bowei bowei Awaiting requested review from bowei

@shaneutt shaneutt Awaiting requested review from shaneutt

@robscott robscott Awaiting requested review from robscott

@candita candita Awaiting requested review from candita

@gauravkghildiyal gauravkghildiyal Awaiting requested review from gauravkghildiyal

Assignees

@youngnick youngnick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BackendTLSPolicy: Add CEL Tests
5 participants
@Ygnas @k8s-ci-robot @robscott @gauravkghildiyal @youngnick