-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phasing out Beta from Versioning Guide #2446
Conversation
@robscott: GitHub didn't allow me to request PR reviews from the following users: candita, gcs278. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
857be57
to
b8b134a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just have some nit picks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -3,19 +3,24 @@ | |||
* Issue: [#922](https://github.com/kubernetes-sigs/gateway-api/issues/922) | |||
* Status: Standard | |||
|
|||
!!! note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is !!! note
intended to be as it is? I see no fancy markdown stuff being rendered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's rendered in the deploy preview - this is a directive to mkdocs
, not a standard Markdown one.
Thanks everyone for the feedback! I think I've addressed everything, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
I think this change makes sense as we approach GA (where users should be able to expect the CRDs commonly installed by default to be stable and to not have breaking changes) and will help reduce the combinatorial complexity of understanding how release channels interact with API resource versioning. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kflynn, mikemorris, mlavacca, robscott, sunjayBhatia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks everyone for the feedback! I think I've resolved everything now, PTAL. |
I think we've got enough consensus here, going to remove the hold so the next LGTM merges this. /hold cancel |
/lgtm |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This is a long overdue follow up from my original proposal to phase out beta from Gateway API versioning. Earlier this year, we presented this idea to SIG Network (Jan 19), Gateway API (Jan 23 and Aug 21), and SIG Architecture (Jan 26) meetings. In all cases, I believe we had consensus to move forward with this approach, I just needed to translate the proposal into reality.
With the upcoming v1.0 release of Gateway API, the time has come to define exactly how our versioning policy will work with GA APIs. As I'm doing that, I'm also taking the opportunity to translate this earlier proposal into reality.
Does this PR introduce a user-facing change?:
This is a big change that will have a lasting impact on the API. Asking for lots of reviewers here. As always, please don't hesitate to review if I didn't list you below, trying to not mention too many people here, but everyone's input is appreciated.
/hold for consensus
/cc @arkodg @candita @gcs278 @mlavacca @sunjayBhatia
/assign @shaneutt @youngnick