-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial GAMMA docs take #2238
Initial GAMMA docs take #2238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome 👍 👍
I left a bunch of nitpicks, nothing blocking at all though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, nice work @kflynn.
The big question I have though is: do we have a backup plan for if we have to pivot away from Service binding? This PR effectively cements Service binding as the future, and if we change our mind, it will get fiddly.
I guess I'm really asking: at this point, is there any possibility we will use something other than Service binding as the main east/west approach?
If not, awesome, we're good.
If there is even a slim chance, we may need to put some more callouts and caveats that the service binding approach is still experimental and could change.
Like I said in one of my comments, I really want to avoid another Policy Attachment error - where the docs accidentally make something look more stable than it actually is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work on this @kflynn! This is really great!
I think feedback other than renaming Charlie to Chihiro has been addressed in the current commits -- commenters (@youngnick, @robscott, @howardjohn) please check to see that things look good to you! Since I've pointed to specific commits in comments, I'll rebase after folks take a look. 🙂 |
Signed-off-by: [email protected]
Signed-off-by: [email protected]
Signed-off-by: [email protected]
Signed-off-by: [email protected]
Signed-off-by: [email protected]
Signed-off-by: [email protected]
Signed-off-by: [email protected]
Signed-off-by: [email protected]
…navbar. Signed-off-by: [email protected]
Signed-off-by: [email protected]
Signed-off-by: [email protected]
…umes the contributing-to-GAMMA page. Signed-off-by: [email protected]
Signed-off-by: [email protected]
I've marked this ready for review since I think we're pretty close at this point. |
This LGTM, and is an excellent addition. Thanks @kflynn! /approved |
Love this! Thanks flynn |
/lgtm |
I think @youngnick meant /approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: keithmattix, kflynn, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Initial cut of GAMMA website updates
Signed-off-by: [email protected]
/kind documentation