Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial conformance results for Contour #2237

Conversation

sunjayBhatia
Copy link
Member

What type of PR is this?

/area conformance

What this PR does / why we need it:

Adds initial conformance results for Contour's Gateway API implementation

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/conformance labels Jul 25, 2023
@k8s-ci-robot k8s-ci-robot requested review from kflynn and Xunzhuo July 25, 2023 22:22
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2023
statistics:
Failed: 0
Passed: 9
Skipped: 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to #2206 this is not accurate

organization: projectcontour
project: contour
url: https://github.com/projectcontour/contour
version: "f6c112e60a40ceb9d448354473a8fe7d1a726790"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current Contour main branch commit

@sunjayBhatia
Copy link
Member Author

/cc @skriss

@k8s-ci-robot k8s-ci-robot requested a review from skriss July 25, 2023 22:23
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for filing a report! Just need to identify which Gateway API version this report is for and then LGTM.

conformance/results/contour.yaml Outdated Show resolved Hide resolved
@shaneutt shaneutt self-assigned this Jul 26, 2023
@shaneutt shaneutt requested a review from mlavacca July 26, 2023 13:20
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than TODO gwapi version.

Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia sunjayBhatia requested a review from shaneutt July 27, 2023 14:21
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks for reporting!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaneutt, sunjayBhatia, Xunzhuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fe202d4 into kubernetes-sigs:main Jul 27, 2023
@sunjayBhatia sunjayBhatia deleted the contour-initial-conformance-report branch July 27, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants