-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial conformance results for Contour #2237
Add initial conformance results for Contour #2237
Conversation
Signed-off-by: Sunjay Bhatia <[email protected]>
statistics: | ||
Failed: 0 | ||
Passed: 9 | ||
Skipped: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due to #2206 this is not accurate
organization: projectcontour | ||
project: contour | ||
url: https://github.com/projectcontour/contour | ||
version: "f6c112e60a40ceb9d448354473a8fe7d1a726790" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current Contour main
branch commit
/cc @skriss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for filing a report! Just need to identify which Gateway API version this report is for and then LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than TODO
gwapi version.
Signed-off-by: Sunjay Bhatia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Thanks for reporting!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaneutt, sunjayBhatia, Xunzhuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area conformance
What this PR does / why we need it:
Adds initial conformance results for Contour's Gateway API implementation
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: