conformance: Make routability tests runnable #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix manifest file names - gateway names/typos - move to testify require statements to prevent tests to continue to execute when preconditions not met (to prevent panics) and to simplify test logic Other issues still remain, this does not make a guarantee the logic of these tests is correct since there is no implementation that supports them yet. Signed-off-by: Sunjay Bhatia <[email protected]>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/M
|
/cc @dprotaso |
sunjayBhatia
changed the title
|
Thanks @sunjayBhatia! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, robscott, sunjayBhatia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
/kind test
/area conformance
What this PR does / why we need it:
The new routability tests are not runnable, they are not included in the set of all features and also have various issues
Other issues still remain and will be covered in subsequent issues for discussion, this does not make a guarantee the logic of these tests is correct since there is no implementation that supports them yet.
Which issue(s) this PR fixes:
Fixes #2204
Does this PR introduce a user-facing change?: