Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance Profiles (GEP 1709) to Experimental status #2180

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Conformance Profiles (GEP 1709) to Experimental status #2180

merged 5 commits into from
Jul 12, 2023

Conversation

shaneutt
Copy link
Member

What type of PR is this?

/kind cleanup
/kind gep

What this PR does / why we need it:

In support of #1709 this moves the GEP to Experimental status, ready for implementations to start submitting their reports.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/gep PRs related to Gateway Enhancement Proposal(GEP) do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 11, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2023
@shaneutt shaneutt marked this pull request as ready for review July 11, 2023 15:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@k8s-ci-robot k8s-ci-robot requested a review from howardjohn July 11, 2023 15:10
@shaneutt
Copy link
Member Author

/cc @sunjayBhatia @arkodg @mlavacca @michaelbeaumont

robscott
robscott reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shaneutt!

/approve

geps/gep-1709.md Show resolved Hide resolved
@shaneutt shaneutt requested a review from robscott July 11, 2023 20:21
mlavacca
mlavacca approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shaneutt!

@shaneutt shaneutt removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, mlavacca, robscott, shaneutt, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaneutt shaneutt force-pushed the shaneutt/move-profiles-to-exp branch from d572ebc to 243f087 Compare July 12, 2023 15:11
@shaneutt shaneutt force-pushed the shaneutt/move-profiles-to-exp branch from 243f087 to 7671e03 Compare July 12, 2023 15:28
@robscott
Copy link
Member

Thanks @shaneutt and @mlavacca!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5fd55ab into kubernetes-sigs:main Jul 12, 2023
@shaneutt shaneutt deleted the shaneutt/move-profiles-to-exp branch July 12, 2023 16:52
michaelbeaumont
michaelbeaumont reviewed Jul 27, 2023
View reviewed changes
geps/overview.md
@@ -71,7 +71,8 @@ proposed changes in our API. In some cases, these changes will be documentation
only, but in most cases, some API changes will also be required. It is important
that every new feature of the API is marked as "Experimental" when it is
introduced. Within the API, we use `<gateway:experimental>` tags to denote
experimental fields.
experimental fields. Within Golang packages (conformance tests, CLIs, e.t.c.) we
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original justification for the build flag was provisional status of the GEP. Is the flag still necessary now that it's experimental? @shaneutt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's a replacement for the normal CLI and test suite, the intention was to leave it, however I suppose we can have a discussion about removing the build tag if that's helpful to people. 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build tag is a (soft) blocker for our adoption personally

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be in favor of dropping experimental build tag here, ideally pre-0.8.0 so it's a bit easier to report results.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good #2242

@shaneutt shaneutt mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont left review comments

@mlavacca mlavacca mlavacca approved these changes

@arkodg arkodg arkodg approved these changes

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@keithmattix keithmattix Awaiting requested review from keithmattix

@howardjohn howardjohn Awaiting requested review from howardjohn

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shaneutt @k8s-ci-robot @robscott @howardjohn @michaelbeaumont @sunjayBhatia @arkodg @mlavacca