-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only require a GatewayClass if the gateway suite is being run #2164
Conversation
Signed-off-by: Alex Leong <[email protected]>
Welcome @adleong! |
Hi @adleong. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
Thanks @adleong! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adleong, arkodg, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@adleong It looks like golangci-lint is failing:
Whenever you get time to fix that we should be good to merge this. |
@adleong Do you have time to take a look at the linting issue here? Would love to get this one in before v0.8.0 if you've got time for it. |
Yes, sorry for the delay. I'll try to get this fixed up today. |
Signed-off-by: Alex Leong <[email protected]>
Thanks @adleong! /lgtm |
/kind test
/area conformance
What this PR does / why we need it:
When the conformance tests run, they require that a GatewayClass exists and that it has been accepted. However, this is not appropriate when testing mesh only conformance because mesh implementations do not necessarily have a GatewayClass. This change moves the GatewayClass requirement into the Gateway suite so that this is only checked when the Gateway feature is enabled.
Does this PR introduce a user-facing change?: