-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conformance tests with requestHeaderModifier #2101
Add conformance tests with requestHeaderModifier #2101
Conversation
…ended Capabilities such as requestMirror, responseHeaderModifier, and urlRewrite
Welcome @Treenhan! |
Hi @Treenhan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @LiorLieberman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz sign CLA first @Treenhan, Thanks! |
I just created CLA approval request, currently waiting on that to go through |
Hi @robscott could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Treenhan! This is great! Nothing blocking here, but a couple small nits. Would appreciate a review from others here as well:
/cc @arkodg @mlavacca @michaelbeaumont @sunjayBhatia @Xunzhuo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test all pass with contour 👍🏽
/retest |
@Treenhan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks @Treenhan! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, Treenhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind test
/area conformance
What this PR does / why we need it:
Adding conformance testing by combining one Core Capability (i.e. requestHeaderModifier) wither other Extended Capabilities (i.e. requestMirror, responseHeaderModifier, and urlRewrite)
Which issue(s) this PR fixes:
Fixes #2037