Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docstring for ReplacePrefixMatch. #2079

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

briantkennedy
Copy link
Contributor

Make example text clearer and add table of replacement cases.

What type of PR is this?
/kind documentation

Optionally add one or more of the following kinds if applicable:
/area conformance

What this PR does / why we need it:

The docstring is a bit unclear, and edge cases are not explicitly defined.

Which issue(s) this PR fixes:
Fixes #2078

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 31, 2023
@k8s-ci-robot k8s-ci-robot requested review from bowei and shaneutt May 31, 2023 19:50
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @briantkennedy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @briantkennedy!

/ok-to-test

apis/v1beta1/httproute_types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2023
@robscott
Copy link
Member

robscott commented Jun 5, 2023

Thanks @briantkennedy! Do you mind running make generate to get the presubmits to pass? Otherwise this LGTM.

// /foo/bar | /foo/ | /xyz | /xyz/bar
// /foo/bar | /foo/ | /xyz/ | /xyz/bar
// /foo | /foo | /xyz | /xyz
// /foo/ | /foo | /xyz | /xyz/
Copy link
Member

@robscott robscott Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the key detail. This should work well for Envoy-based implementations, but it would be good to get some representatives from other implementations to confirm this will be compatible for them as well.

/cc @shaneutt @mlavacca @pleshakov @brianehlert @kflynn

@k8s-ci-robot k8s-ci-robot requested a review from mlavacca June 5, 2023 23:06
@k8s-ci-robot
Copy link
Contributor

@robscott: GitHub didn't allow me to request PR reviews from the following users: pleshakov, brianehlert.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

I think this is the key detail. This should work well for Envoy-based implementations, but it would be good to get some representatives from other implementations to confirm this will be compatible for them as well.

/cc @shaneutt @mlavacca @pleshakov @brianehlert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@robscott robscott requested a review from kflynn June 5, 2023 23:07
Make example text clearer and add table of replacement cases.
@robscott
Copy link
Member

Thanks @briantkennedy!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briantkennedy, mlavacca, pleshakov, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 19fa133 into kubernetes-sigs:main Jun 14, 2023
@briantkennedy briantkennedy deleted the issue-2078 branch June 27, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify path prefix rewrite / redirect docs for HTTPPathModifier
5 participants