-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify docstring for ReplacePrefixMatch. #2079
Conversation
Hi @briantkennedy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @briantkennedy!
/ok-to-test
Thanks @briantkennedy! Do you mind running |
// /foo/bar | /foo/ | /xyz | /xyz/bar | ||
// /foo/bar | /foo/ | /xyz/ | /xyz/bar | ||
// /foo | /foo | /xyz | /xyz | ||
// /foo/ | /foo | /xyz | /xyz/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the key detail. This should work well for Envoy-based implementations, but it would be good to get some representatives from other implementations to confirm this will be compatible for them as well.
@robscott: GitHub didn't allow me to request PR reviews from the following users: pleshakov, brianehlert. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Make example text clearer and add table of replacement cases.
54a3a7f
to
a83eb80
Compare
Thanks @briantkennedy! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briantkennedy, mlavacca, pleshakov, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Make example text clearer and add table of replacement cases.
What type of PR is this?
/kind documentation
Optionally add one or more of the following kinds if applicable:
/area conformance
What this PR does / why we need it:
The docstring is a bit unclear, and edge cases are not explicitly defined.
Which issue(s) this PR fixes:
Fixes #2078
Does this PR introduce a user-facing change?: