Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s.io to v0.27.1 #1956

Merged
merged 10 commits into from
May 16, 2023
Merged

Bump k8s.io to v0.27.1 #1956

merged 10 commits into from
May 16, 2023

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Apr 20, 2023 •
edited
Loading

What type of PR is this?

/kind test

What this PR does / why we need it:

Bump k8s.io to v0.27.1

Which issue(s) this PR fixes:

Fixes #1942

Does this PR introduce a user-facing change?:

Bump k8s.io to v0.27.1

@k8s-ci-robot k8s-ci-robot requested review from bowei and robscott April 20, 2023 03:02
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @zirain. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 20, 2023
@arkodg
Copy link
Contributor

arkodg commented Apr 20, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 20, 2023
@zirain
Copy link
Contributor Author

zirain commented Apr 20, 2023

@shaneutt seems everything is pass now.

shaneutt
shaneutt requested changes Apr 20, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on. I have some comments relevant to timeouts set, and in general it would be helpful if the lint failure which was the impetus for a change here was commented along with the diff i you could please.

cmd/admission/main.go Outdated Show resolved Hide resolved
conformance/utils/kubernetes/helpers.go Outdated Show resolved Hide resolved
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 20, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 20, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 20, 2023
sunjayBhatia
sunjayBhatia reviewed Apr 20, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@zirain zirain requested a review from shaneutt April 20, 2023 14:37
@shaneutt shaneutt mentioned this pull request Apr 21, 2023
Closed
@zirain zirain requested a review from howardjohn April 21, 2023 08:50
@zirain
Copy link
Contributor Author

zirain commented Apr 21, 2023

@shaneutt anything left?

@shaneutt
Copy link
Member

Sorry for the slow responses, last week was Kubecon week and it was incredibly busy. I'll take another pass at this soon.

@shaneutt shaneutt added this to the v0.8.0 milestone Apr 24, 2023
@shaneutt
Copy link
Member

merge conflict needs fixing when you have a second, I resolved a couple of open comments 👍

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2023
zirain added 3 commits April 25, 2023 08:52
@zirain
Bump k8s.io
40f79d6 
Signed-off-by: hejianpeng <[email protected]>
@zirain
fix lint
cbcb174 
Signed-off-by: hejianpeng <[email protected]>
@zirain
fix more
0253084 
Signed-off-by: hejianpeng <[email protected]>
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
@shaneutt
Copy link
Member

Looks good, would like a double check from another maintainer

/cc @youngnick @robscott

@k8s-ci-robot k8s-ci-robot requested a review from youngnick April 26, 2023 17:26
@zirain zirain requested a review from robscott April 27, 2023 17:01
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 4, 2023
robscott
robscott reviewed May 4, 2023
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zirain! This change LGTM, but given the scale of the chance and that we're about to cut our final v0.7.0 release, I'd rather hold off on merging this until that releases.

/hold

conformance/utils/kubernetes/helpers.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
shaneutt
shaneutt approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good, just still waiting on the v0.7.0 hold for branching.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaneutt, zirain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zirain
Copy link
Contributor Author

zirain commented May 16, 2023

kindly ping @robscott , can this get in now?

@shaneutt shaneutt requested a review from robscott May 16, 2023 11:45
@robscott robscott added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 16, 2023
@robscott
Copy link
Member

Thanks @zirain!

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2023
@robscott robscott mentioned this pull request May 16, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit cee1710 into kubernetes-sigs:main May 16, 2023
@zirain zirain deleted the bump-k8s.io branch May 17, 2023 00:04
@shaneutt shaneutt mentioned this pull request Jul 24, 2023
Closed
@shaneutt shaneutt mentioned this pull request Aug 7, 2023
Closed
@shaneutt shaneutt mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia left review comments

@shaneutt shaneutt shaneutt approved these changes

@bowei bowei Awaiting requested review from bowei

@howardjohn howardjohn Awaiting requested review from howardjohn

@youngnick youngnick Awaiting requested review from youngnick

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
7 participants
@zirain @k8s-ci-robot @arkodg @shaneutt @robscott @howardjohn @sunjayBhatia