-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add goals and intro for conformance profiles GEP #1739
docs: add goals and intro for conformance profiles GEP #1739
Conversation
Skipping CI for Draft Pull Request. |
This LGTM as starting point, thanks @shaneutt! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @shaneutt!
I like the idea of splitting it to iterations, thanks @shaneutt ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, shaneutt, Xunzhuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Forgot to put a hold on this to allow @robscott and/or @youngnick to give it a look. Please do one or both of you check it out, but given that it's |
That sounds fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shaneutt! LGTM other than one small nit that can be a follow up.
@@ -0,0 +1,44 @@ | |||
# GEP-1709: Conformance Profiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a link in mkdocs.yml since we haven't automated this yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will follow up, thank you 👍
What type of PR is this?
/kind gep
What this PR does / why we need it:
This is one of several issues needed in support of #1709.
This is meant to be a small initial iteration to make sure we have alignment on the "what" and "why" by way of the tldr, goals and introduction, but not bothering yet with the how. The hope is that if we have alignment follow up iterations can be responsible for filling in the "how". Please feel very free to add suggestions for anything you want to see changed or added, I want to incorporate and co-author this with anyone with ideas and interest.