Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add goals and intro for conformance profiles GEP #1739

Merged

Conversation

shaneutt
Copy link
Member

@shaneutt shaneutt commented Feb 17, 2023

What type of PR is this?

/kind gep

What this PR does / why we need it:

This is one of several issues needed in support of #1709.

This is meant to be a small initial iteration to make sure we have alignment on the "what" and "why" by way of the tldr, goals and introduction, but not bothering yet with the how. The hope is that if we have alignment follow up iterations can be responsible for filling in the "how". Please feel very free to add suggestions for anything you want to see changed or added, I want to incorporate and co-author this with anyone with ideas and interest.

@shaneutt shaneutt added kind/gep PRs related to Gateway Enhancement Proposal(GEP) area/conformance labels Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2023
@shaneutt shaneutt marked this pull request as ready for review February 17, 2023 17:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2023
@k8s-ci-robot k8s-ci-robot requested a review from bowei February 17, 2023 17:59
@youngnick
Copy link
Contributor

This LGTM as starting point, thanks @shaneutt!

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @shaneutt!

@LiorLieberman
Copy link
Member

I like the idea of splitting it to iterations, thanks @shaneutt !
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, shaneutt, Xunzhuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LiorLieberman LiorLieberman removed their assignment Feb 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit fe4322c into kubernetes-sigs:main Feb 21, 2023
@shaneutt shaneutt changed the title docs: add goals and intro for conformane profiles GEP docs: add goals and intro for conformance profiles GEP Feb 21, 2023
@shaneutt shaneutt deleted the shaneutt/conformance-profiles-gep branch February 21, 2023 18:04
@shaneutt shaneutt restored the shaneutt/conformance-profiles-gep branch February 21, 2023 18:04
@shaneutt shaneutt deleted the shaneutt/conformance-profiles-gep branch February 21, 2023 18:05
@shaneutt
Copy link
Member Author

Forgot to put a hold on this to allow @robscott and/or @youngnick to give it a look. Please do one or both of you check it out, but given that it's provisional I think it's reasonable to make small PRs for any changes or adjustments desired now, rather than reverting?

@youngnick
Copy link
Contributor

That sounds fine to me.

Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shaneutt! LGTM other than one small nit that can be a follow up.

@@ -0,0 +1,44 @@
# GEP-1709: Conformance Profiles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a link in mkdocs.yml since we haven't automated this yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will follow up, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants