conformance: HTTPRoute and not allowing listener #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
cncf-cla: yes
mlavacca
force-pushed
the
fix-conformance-http-disallowed-kind
branch
from
fa316d5 to
aab4867
Compare
shaneutt
reviewed
Jan 23, 2023
When a Route references a gateway having no listener whose allowedRoutes criteria permit the route, the reason NotAllowedByListeners should be used for the accepted condition. Signed-off-by: Mattia Lavacca <[email protected]>
mlavacca
force-pushed
the
fix-conformance-http-disallowed-kind
branch
from
aab4867 to
7a5e981
Compare
k8s-ci-robot
added
size/M
mlavacca
requested review from
shaneutt
and removed request for
bowei and
youngnick
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
shaneutt
pushed a commit
that referenced
this pull request
Feb 7, 2023
…d-kind conformance: HTTPRoute and not allowing listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
When a Route references a gateway having no listener whose
allowedRoutescriteria permit the route, the reasonNotAllowedByListenersshould be used for theacceptedcondition.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: