Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen Accepted check in GWC Obs Generation test #1655

Merged
merged 4 commits into from
Jan 25, 2023
Merged

Loosen Accepted check in GWC Obs Generation test #1655

merged 4 commits into from
Jan 25, 2023

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jan 18, 2023

  • enhance GWCMustBeAccepted to pass a status value along, an empty string indicates, any status value is matched.

  • Loosen the check within GatewayClassObservedGenerationBump to wait for the Accepted condition to have any status value

Relates to https://kubernetes.slack.com/archives/CR0H13KGA/p1673836949189379?thread_ts=1673599220.709819&cid=CR0H13KGA

Signed-off-by: Arko Dasgupta [email protected]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

@arkodg
Loosen Accepted check in GWC Obs Generation test
e5b2de3 
* enhance `GWCMustBeAccepted` to pass a status value along,
an empty string indicates, any status value is matched.

* Loosen the check within `GatewayClassObservedGenerationBump`
to wait for the `Accepted` condition to have any status value

Relates to https://kubernetes.slack.com/archives/CR0H13KGA/p1673836949189379?thread_ts=1673599220.709819&cid=CR0H13KGA

Signed-off-by: Arko Dasgupta <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @arkodg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arkodg arkodg mentioned this pull request Jan 18, 2023
Merged
@gyohuangxin
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 19, 2023
shaneutt
shaneutt reviewed Jan 19, 2023
View reviewed changes
conformance/utils/kubernetes/helpers.go Outdated Show resolved Hide resolved
conformance/utils/kubernetes/helpers.go Outdated Show resolved Hide resolved
conformance/utils/suite/suite.go Outdated Show resolved Hide resolved
@arkodg arkodg requested review from shaneutt and removed request for bowei and mikemorris January 19, 2023 18:36
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2023
arkodg added 2 commits January 19, 2023 10:44
@arkodg
typecast metav1.ConditionTrue to string
5b81398 
Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg
method name typo
21d969f 
Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg
Copy link
Contributor Author

arkodg commented Jan 23, 2023

ptal @youngnick

@shaneutt shaneutt requested a review from youngnick January 23, 2023 18:38
shaneutt
shaneutt approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new functional approach, thank you. This LGTM but I'll let one other put the final label on it. 👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2023
@arkodg arkodg mentioned this pull request Jan 24, 2023
Closed
@Xunzhuo
Copy link
Member

Xunzhuo commented Jan 25, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8043dfb into kubernetes-sigs:main Jan 25, 2023
@arkodg arkodg deleted the gc-bump-accepted branch January 25, 2023 01:19
@shaneutt shaneutt added this to the v0.6.1 milestone Feb 7, 2023
shaneutt pushed a commit that referenced this pull request Feb 7, 2023
@k8s-ci-robot @shaneutt
Merge pull request #1655 from arkodg/gc-bump-accepted
2432c5c 
Loosen `Accepted` check in GWC Obs Generation test
@arkodg arkodg mentioned this pull request Mar 7, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@Xunzhuo Xunzhuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.
5 participants
@arkodg @k8s-ci-robot @gyohuangxin @Xunzhuo @shaneutt