Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http rewrite conformance #1622

Merged
merged 4 commits into from
Jan 3, 2023
Merged

Http rewrite conformance #1622

merged 4 commits into from
Jan 3, 2023

Conversation

LiorLieberman
Copy link
Member

@LiorLieberman LiorLieberman commented Dec 28, 2022 •
edited
Loading

What type of PR is this?
/kind feature
/area conformance

What this PR does / why we need it:
Add tests for http rewrite

Which issue(s) this PR fixes:

Issue #1103

Does this PR introduce a user-facing change?:

- Added: conformance tests for http rewrite host and path filters.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @LiorLieberman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 28, 2022
robscott
robscott reviewed Dec 29, 2022
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LiorLieberman!

/ok-to-test

conformance/tests/httproute-rewrite-path.yaml Outdated Show resolved Hide resolved
conformance/tests/httproute-rewrite-path.go Show resolved Hide resolved
conformance/tests/httproute-rewrite-host.go Show resolved Hide resolved
conformance/tests/httproute-rewrite-path.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 29, 2022
@LiorLieberman LiorLieberman requested review from robscott and removed request for howardjohn and youngnick December 29, 2022 07:14
@robscott
Copy link
Member

Thanks @LiorLieberman! Looks like this has a merge conflict now that other rewrite PR merged. One other note, I think we should actually add release notes for conformance test changes since we've consistently been including conformance test changes in our changelog and release notes. Will LGTM once you rebase and add release note.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 29, 2022
@LiorLieberman LiorLieberman force-pushed the http-rewrite-conformance branch from 936bf35 to 7dc2bca Compare December 31, 2022 11:57
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 31, 2022
@LiorLieberman
Copy link
Member Author

@robscott I have added a note in the PR description - this is how we add release notes right?

@robscott
Copy link
Member

robscott commented Jan 3, 2023

Thanks @LiorLieberman!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 46d4088 into kubernetes-sigs:main Jan 3, 2023
skriss
skriss reviewed Jan 5, 2023
View reviewed changes
conformance/tests/httproute-rewrite-path.yaml
type: ReplaceFullPath
replaceFullPath: /one
backendRefs:
- name: infra-backend-v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be infra-backend-v2 given https://github.com/LiorLieberman/gateway-api/blob/7dc2bcaed9f75a4cf7e6908c4b9262b6c3609fec/conformance/tests/httproute-rewrite-path.go#L66

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

opened #1628 to fix it

@robscott robscott mentioned this pull request Jan 6, 2023
Merged
@LiorLieberman LiorLieberman mentioned this pull request Jan 9, 2023
Closed
9 tasks
@shaneutt shaneutt added this to the v0.6.1 milestone Feb 7, 2023
shaneutt pushed a commit that referenced this pull request Feb 7, 2023
@k8s-ci-robot @shaneutt
Merge pull request #1622 from LiorLieberman/http-rewrite-conformance
e019b23 
Http rewrite conformance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss left review comments

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.
5 participants
@LiorLieberman @k8s-ci-robot @robscott @skriss @shaneutt