conformance: do not use (and mutate) DefaultClient #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a global variable. Since we import the tests and then run other tests, this broke our other tests which depend on DefaultClient.
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/XS
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Dec 21, 2022
Using a single shared client risks other parts of the code (or dependencies) modifying the client and breaking things. See kubernetes-sigs/gateway-api#1617 for an exmaple where this happened. Also fix up paths to avoid `//debug` requests which always get a 301.
shaneutt
approved these changes
Dec 21, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks! /lgtm |
istio-testing
pushed a commit
to istio/istio
that referenced
this pull request
Dec 29, 2022
* Drop `http.DefaultClient` Using a single shared client risks other parts of the code (or dependencies) modifying the client and breaking things. See kubernetes-sigs/gateway-api#1617 for an exmaple where this happened. Also fix up paths to avoid `//debug` requests which always get a 301. * fix test * fix
shaneutt
pushed a commit
that referenced
this pull request
Feb 7, 2023
conformance: do not use (and mutate) DefaultClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a global variable. Since we import the tests and then run other tests, this broke our other tests which depend on DefaultClient.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: