-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s.io deps to v0.26.0 #1595
Conversation
Welcome @lucacome! |
Hi @lucacome. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and welcome!
Looks right, I checked it out locally and tidy and verify are happy with it.
/ok-to-test
@lucacome out of curiosity is part of the impetus for this PR because you're importing Gateway API as a Go library at NGinx?
6f1ecb5
to
aad6860
Compare
Hi @shaneutt yeah that's part of it, but just making an effort to keep all the k8s dependencies up to date in various projects 🙂 |
Signed-off-by: Luca Comellini <[email protected]>
aad6860
to
a94e761
Compare
Some of the k8s deps were updated in #1601 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked it out locally again,
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucacome, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates k8s.io dependencies to
v0.26.0
Does this PR introduce a user-facing change?: