chore: cleanup for #1538 #1569
Merged
chore: cleanup for #1538 #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
size/L
shaneutt
force-pushed
the
shaneutt/referencegrant-godoc-updates
branch
from
f8ca3ac to
a1e5a46
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
LGTM, but I'll leave this for one more approval. |
gyohuangxin
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
I leave LTGM because some of the code here was written by me before, thanks for improving. @shaneutt
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gyohuangxin, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
robscott
added a commit
to robscott/gateway-api
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several smaller cleanup items from feedback on #1538