-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance Tests: TLSRoute Passthrough #1579
Comments
Thanks @candita! I think it would be worth differentiating between tests of our API validation and tests of the actual underlying implementation. At least so far, I've been working with the assumption that conformance tests are only intended to cover implementation details, not our CRD or webhook validation. #1514 has a bit more context on that discussion though. |
I agree that for now, if one of these cases is covered by CRD validation, webhook validation, or both, we can check it off, and then come back to testing it as part of sorting out #1514. |
Does this adjusted list make more sense @robscott @youngnick ? |
Yep, that looks great, thanks @candita! |
Suggested additions to the list of conformance tests since we've discussed disallowing
|
Those additions look great, thanks @mikemorris. |
…mative) rebase
I added these to the description so they wouldn't get lost. Can you provide more detail about this could probably be validated by webhook too? It's just a comment, not a test, right? |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
This is a blocker for #2643. |
Updating my prior comment about Refs Slack thread, #1474 and #2111 /cc @kate-osborn |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle-stale |
/lifecycle frozen |
This issue is intended to track conformance test development for TLSRoute Passthrough. Comment below if you're interested in working on covering any of these areas.
Core Capabilities:
- [ ] Invalid TLSRoute - no backendRef/rule doesn't become Ready- [ ] Invalid TLSRoute - invalid backendRef/rule doesn't become Ready (some or all from sublist?)- [ ] Missing Rule- [ ] Missing Port- [ ] Kind, if not nil, is also not Service- [ ] Multi ParentRef sections names not set- [ ] Multi ParentRef sections names not unique- [ ] SNI hostname invalid - IP address- [ ] SNI hostname invalid - not RFC1123, not wildcard prefix- [ ] More than 16 hostnames- [ ] More than 16 rules- [ ] More than 16 backendRef-[ ] Invalid TLSRoute with 1 backendRef/Rule that doesn’t exist performs no default forwarding- [ ] Name not set- [ ] Kind not set- [ ] Port missing when Kind is ServiceThe text was updated successfully, but these errors were encountered: