Merge pull request #837 from howardjohn/mirror/backend-required

Make MirrorFilter.BackendRef required
kubernetes-sigs · Aug 30, 2021 · a4fc2e2 · a4fc2e2
2 parents bd2a154 + 4c171a6
commit a4fc2e2
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 16 deletions.
diff --git a/apis/v1alpha2/httproute_types.go b/apis/v1alpha2/httproute_types.go
@@ -722,9 +722,7 @@ type HTTPRequestMirrorFilter struct {
 	//
 	// Support: Extended for Kubernetes Service
 	// Support: Custom for any other resource
-	//
-	// +optional
-	BackendRef *BackendObjectReference `json:"backendRef,omitempty"`
+	BackendRef BackendObjectReference `json:"backendRef"`
 }
 
 // HTTPBackendRef defines how a HTTPRoute should forward an HTTP request.

diff --git a/apis/v1alpha2/validation/httproute_test.go b/apis/v1alpha2/validation/httproute_test.go
@@ -81,7 +81,7 @@ func TestValidateHTTPRoute(t *testing.T) {
 								{
 									Type: gatewayv1a2.HTTPRouteFilterRequestMirror,
 									RequestMirror: &gatewayv1a2.HTTPRequestMirrorFilter{
-										BackendRef: &gatewayv1a2.BackendObjectReference{
+										BackendRef: gatewayv1a2.BackendObjectReference{
 											Name: testService,
 											Port: portNumberPtr(8081),
 										},
@@ -112,7 +112,7 @@ func TestValidateHTTPRoute(t *testing.T) {
 								{
 									Type: gatewayv1a2.HTTPRouteFilterRequestMirror,
 									RequestMirror: &gatewayv1a2.HTTPRequestMirrorFilter{
-										BackendRef: &gatewayv1a2.BackendObjectReference{
+										BackendRef: gatewayv1a2.BackendObjectReference{
 											Name: testService,
 											Port: portNumberPtr(8080),
 										},
@@ -121,7 +121,7 @@ func TestValidateHTTPRoute(t *testing.T) {
 								{
 									Type: gatewayv1a2.HTTPRouteFilterRequestMirror,
 									RequestMirror: &gatewayv1a2.HTTPRequestMirrorFilter{
-										BackendRef: &gatewayv1a2.BackendObjectReference{
+										BackendRef: gatewayv1a2.BackendObjectReference{
 											Name: specialService,
 											Port: portNumberPtr(8080),
 										},
@@ -163,7 +163,7 @@ func TestValidateHTTPRoute(t *testing.T) {
 								{
 									Type: gatewayv1a2.HTTPRouteFilterRequestMirror,
 									RequestMirror: &gatewayv1a2.HTTPRequestMirrorFilter{
-										BackendRef: &gatewayv1a2.BackendObjectReference{
+										BackendRef: gatewayv1a2.BackendObjectReference{
 											Name: testService,
 											Port: portNumberPtr(8080),
 										},
@@ -205,7 +205,7 @@ func TestValidateHTTPRoute(t *testing.T) {
 								{
 									Type: gatewayv1a2.HTTPRouteFilterRequestMirror,
 									RequestMirror: &gatewayv1a2.HTTPRequestMirrorFilter{
-										BackendRef: &gatewayv1a2.BackendObjectReference{
+										BackendRef: gatewayv1a2.BackendObjectReference{
 											Name: testService,
 											Port: portNumberPtr(8080),
 										},
@@ -225,7 +225,7 @@ func TestValidateHTTPRoute(t *testing.T) {
 								{
 									Type: gatewayv1a2.HTTPRouteFilterRequestMirror,
 									RequestMirror: &gatewayv1a2.HTTPRequestMirrorFilter{
-										BackendRef: &gatewayv1a2.BackendObjectReference{
+										BackendRef: gatewayv1a2.BackendObjectReference{
 											Name: testService,
 											Port: portNumberPtr(8080),
 										},
@@ -245,7 +245,7 @@ func TestValidateHTTPRoute(t *testing.T) {
 								{
 									Type: gatewayv1a2.HTTPRouteFilterRequestMirror,
 									RequestMirror: &gatewayv1a2.HTTPRequestMirrorFilter{
-										BackendRef: &gatewayv1a2.BackendObjectReference{
+										BackendRef: gatewayv1a2.BackendObjectReference{
 											Name: specialService,
 											Port: portNumberPtr(8080),
 										},
@@ -287,7 +287,7 @@ func TestValidateHTTPRoute(t *testing.T) {
 								{
 									Type: gatewayv1a2.HTTPRouteFilterRequestMirror,
 									RequestMirror: &gatewayv1a2.HTTPRequestMirrorFilter{
-										BackendRef: &gatewayv1a2.BackendObjectReference{
+										BackendRef: gatewayv1a2.BackendObjectReference{
 											Name: testService,
 											Port: portNumberPtr(8080),
 										},

diff --git a/apis/v1alpha2/zz_generated.deepcopy.go b/apis/v1alpha2/zz_generated.deepcopy.go
diff --git a/config/crd/v1alpha2/gateway.networking.k8s.io_httproutes.yaml b/config/crd/v1alpha2/gateway.networking.k8s.io_httproutes.yaml