Skip to content

Commit

Permalink
don't use variadic args - it's unnecessary
Browse files Browse the repository at this point in the history
  • Loading branch information
dprotaso committed Apr 3, 2024
1 parent 3481f69 commit 490ad78
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions conformance/tests/httproute-response-header-modifier.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ var HTTPRouteBackendResponseHeaderModifier = suite.ConformanceTest{
},
Manifests: []string{"tests/httproute-response-header-modifier-backend.yaml"},
Test: func(t *testing.T, suite *suite.ConformanceTestSuite) {
RunHTTPRouteReponseHeaderModifierTest(t, suite, HTTPRouteResponseHeaderModifierTestCases...)
RunHTTPRouteReponseHeaderModifierTest(t, suite, HTTPRouteResponseHeaderModifierTestCases)
},
}

Expand All @@ -57,12 +57,12 @@ var HTTPRouteResponseHeaderModifier = suite.ConformanceTest{
},
Manifests: []string{"tests/httproute-response-header-modifier.yaml"},
Test: func(t *testing.T, suite *suite.ConformanceTestSuite) {
RunHTTPRouteReponseHeaderModifierTest(t, suite, HTTPRouteResponseHeaderModifierTestCases...)
RunHTTPRouteReponseHeaderModifierTest(t, suite, HTTPRouteResponseAndRequestHeaderModifierTestCases...)
RunHTTPRouteReponseHeaderModifierTest(t, suite, HTTPRouteResponseHeaderModifierTestCases)
RunHTTPRouteReponseHeaderModifierTest(t, suite, HTTPRouteResponseAndRequestHeaderModifierTestCases)
},
}

func RunHTTPRouteReponseHeaderModifierTest(t *testing.T, suite *suite.ConformanceTestSuite, testCases ...http.ExpectedResponse) {
func RunHTTPRouteReponseHeaderModifierTest(t *testing.T, suite *suite.ConformanceTestSuite, testCases []http.ExpectedResponse) {
routeNN := types.NamespacedName{Name: "response-header-modifier", Namespace: "gateway-conformance-infra"}
gwNN := types.NamespacedName{Name: "same-namespace", Namespace: "gateway-conformance-infra"}
gwAddr := kubernetes.GatewayAndHTTPRoutesMustBeAccepted(t, suite.Client, suite.TimeoutConfig, suite.ControllerName, kubernetes.NewGatewayRef(gwNN), routeNN)
Expand Down

0 comments on commit 490ad78

Please sign in to comment.