Cleanup from PR feedback

kubernetes-sigs · Dec 15, 2022 · 34f00f8 · 34f00f8
1 parent cd3a100
commit 34f00f8
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 10 deletions.
diff --git a/apis/v1alpha2/validation/grpcroute.go b/apis/v1alpha2/validation/grpcroute.go
@@ -184,14 +184,14 @@ func validateGRPCHeaderModifier(filter gatewayv1a2.HTTPHeaderFilter, path *field
 			singleAction[strings.ToLower(string(action.Name))] = true
 		}
 	}
-	for i, action := range filter.Remove {
-		if needsErr, ok := singleAction[strings.ToLower(action)]; ok {
+	for i, name := range filter.Remove {
+		if needsErr, ok := singleAction[strings.ToLower(name)]; ok {
 			if needsErr {
 				errs = append(errs, field.Invalid(path.Child("remove"), filter.Remove[i], "cannot specify multiple actions for header"))
 			}
-			singleAction[strings.ToLower(action)] = false
+			singleAction[strings.ToLower(name)] = false
 		} else {
-			singleAction[strings.ToLower(action)] = true
+			singleAction[strings.ToLower(name)] = true
 		}
 	}
 	return errs

diff --git a/apis/v1beta1/validation/httproute.go b/apis/v1beta1/validation/httproute.go
@@ -176,7 +176,7 @@ func validateHTTPPathMatch(path *gatewayv1b1.HTTPPathMatch, fldPath *field.Path)
 		r, err := regexp.Compile(validPathCharacters)
 		if err != nil {
 			allErrs = append(allErrs, field.InternalError(fldPath.Child("value"),
-				fmt.Errorf("could not compile path matching regex: %s", err)))
+				fmt.Errorf("could not compile path matching regex: %w", err)))
 		} else if !r.MatchString(*path.Value) {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("value"), *path.Value,
 				fmt.Sprintf("must only contain valid characters (matching %s)", validPathCharacters)))
@@ -321,14 +321,14 @@ func validateHTTPHeaderModifier(filter gatewayv1b1.HTTPHeaderFilter, path *field
 			singleAction[strings.ToLower(string(action.Name))] = true
 		}
 	}
-	for i, action := range filter.Remove {
-		if needsErr, ok := singleAction[strings.ToLower(action)]; ok {
+	for i, name := range filter.Remove {
+		if needsErr, ok := singleAction[strings.ToLower(name)]; ok {
 			if needsErr {
 				errs = append(errs, field.Invalid(path.Child("remove"), filter.Remove[i], "cannot specify multiple actions for header"))
 			}
-			singleAction[strings.ToLower(action)] = false
+			singleAction[strings.ToLower(name)] = false
 		} else {
-			singleAction[strings.ToLower(action)] = true
+			singleAction[strings.ToLower(name)] = true
 		}
 	}
 	return errs

diff --git a/hack/invalid-examples/v1alpha2/grpcroute/invalid-method.yaml b/hack/invalid-examples/v1alpha2/grpcroute/invalid-method.yaml
@@ -10,7 +10,7 @@ spec:
   rules:
   - matches:
     - method:
-      - path: ../
+      - method: ../
     backendRefs:
     - name: bar-svc
       port: 50051
diff --git a/hack/invalid-examples/v1alpha2/grpcroute/invalid-service.yaml b/hack/invalid-examples/v1alpha2/grpcroute/invalid-service.yaml
@@ -0,0 +1,16 @@
+apiVersion: gateway.networking.k8s.io/v1alpha2
+kind: GRPCRoute
+metadata:
+  name: invalid-method
+spec:
+  parentRefs:
+  - name: example-gateway
+  hostnames:
+  - "bar.example.com"
+  rules:
+  - matches:
+    - method:
+      - service: ../
+    backendRefs:
+    - name: bar-svc
+      port: 50051