Skip to content

Commit

Permalink
Add the comment to note AllFeatures must be in sync with the defined …
Browse files Browse the repository at this point in the history
…features when feature constants change.

Signed-off-by: Huang Xin <[email protected]>
  • Loading branch information
gyohuangxin committed Jan 19, 2023
1 parent 4541b10 commit 173f08e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion conformance/utils/flags/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ var (
CleanupBaseResources = flag.Bool("cleanup-base-resources", true, "Whether to cleanup base test resources after the run")
SupportedFeatures = flag.String("supported-features", "", "Supported features included in conformance tests suites")
ExemptFeatures = flag.String("exempt-features", "", "Exempt Features excluded from conformance tests suites")
EnableAllSupportedFeatures = flag.Bool("all-features", false, "Whether to enable all supported feature conformance tests")
EnableAllSupportedFeatures = flag.Bool("all-features", false, "Whether to enable all supported features for conformance tests")
)
3 changes: 3 additions & 0 deletions conformance/utils/suite/suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ var StandardCoreFeatures = map[SupportedFeature]bool{

// AllFeatures contains all the supported features and can be used to run all
// conformance tests with `all-features` flag.
//
// Note that the AllFeatures must in sync with defined features when the
// feature constants change.
var AllFeatures = map[SupportedFeature]bool{
SupportReferenceGrant: true,
SupportTLSRoute: true,
Expand Down

0 comments on commit 173f08e

Please sign in to comment.