Add support for multiple target addresses in CloudFlare provider #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
nta
force-pushed
the
patch/cloudflare-targets
branch
from
8599b6e to
78c3397
Compare
|
Forgot to |
nta
force-pushed
the
patch/cloudflare-targets
branch
from
78c3397 to
cb6970e
Compare
k8s-ci-robot
added
size/L
|
Fixed a test failure by changing the unit test to match the new package-internal interface. |
njuettner
reviewed
Apr 12, 2019
njuettner
reviewed
Apr 12, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #887.
I took a bit of a lazy route to implement this, instead of trying to manage equivalence state for record updates and/or refactoring most the provider, I simply took the same solution rancher/external-dns's CloudFlare provider took, and implemented updates as a sequence of delete + create for all records matching the combination of name and type.
CloudFlare does not seem to support records with real 'sets' of targets in basic DNS - it seems to do so in the additional-cost 'load balancing' product - though this should work well in theory.