Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #672 Cloudflare Link Language Specificity #673

Merged
merged 1 commit into from
Aug 12, 2018

Conversation

christopherhein
Copy link
Member

Why:

  • Cloudflare link shouldn't have the langauge and should rely on the
    browser

This change addresses the need by:

Signed-off-by: Christopher Hein [email protected]

**Why:**

* Cloudflare link shouldn't have the langauge and should rely on the
  browser

**This change addresses the need by:**

* closes kubernetes-sigs#672

Signed-off-by: Christopher Hein <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2018
Copy link
Contributor

@Raffo Raffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Raffo Raffo merged commit c090c98 into kubernetes-sigs:master Aug 12, 2018
@Raffo
Copy link
Contributor

Raffo commented Aug 12, 2018

Thanks for the fix @christopherhein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudflare Link Is Language Specific
3 participants