chore(chart): Adding extra containers

[omerap12]

Description

Introduced an option to either create the Service resource or not, with the default behavior set to create.
Added the capability to include extra containers in the deployment.

Fixes #4280

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Hi @omerap12. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stevehipwell]

@omerap12 thanks for the PR. My suggestion would be to split the PR in half as the extra containers pattern is is fairly basic, but removing the service has additional implications. For example if you're disabling the Service there needs to be conditional logic to swap out the ServiceMonitor for a PodMonitor and both the API and docs would need carful consideration.

In addition could you please make sure to not break file line endings (see service.yaml) and to add changes to the chart CHANGELOG.

[omerap12]

@omerap12 thanks for the PR. My suggestion would be to split the PR in half as the extra containers pattern is is fairly basic, but removing the service has additional implications. For example if you're disabling the Service there needs to be conditional logic to swap out the ServiceMonitor for a PodMonitor and both the API and docs would need carful consideration.

In addition could you please make sure to not break file line endings (see service.yaml) and to add changes to the chart CHANGELOG.

Understood. Ill create the first PR for now. Ill fix the issues you have mentioned above ( and make sure to add the changes to the CHANGELOG as well ).

[stevehipwell]

Just one suggestion to look at. Could you also change the PR title?

[omerap12]

@stevehipwell Done.

[stevehipwell]

@omerap12 you need to re-run helm-docs and then we can run the tests and get this merged.

/label tide/merge-method-squash

[omerap12]

@omerap12 you need to re-run helm-docs and then we can run the tests and get this merged.

/label tide/merge-method-squash

yeap, sorry I forgot :)

[stevehipwell]

/ok-to-test

[stevehipwell]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [stevehipwell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment