add soft error

[jeanfrancoislelezec]

Description

Implementation of softerror on the azure provider to avoid restarting when the azure api is throttling

Fixes #ISSUE #4198 4198

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jeanfrancoislelezec (1b79fca)

[k8s-ci-robot]

Welcome @jeanfrancoislelezec!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jeanfrancoislelezec. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeanfrancoislelezec]

/assign @johngmyers

[mloiseleur]

/ok-to-test
/lgtm
/assign @szuecs

[mloiseleur]

@jeanfrancoislelezec After second thought, I'm unsure 🤔 . Wdyt of a retry mechanism ? Or extending default timeout for Azure ?

[jeanfrancoislelezec]

Currently I'm not sure that retry is implemented on azure provider and /or azure dns go sdk. I just quickly fixed like it done for aws. Today when 429 occurred the process is stopped and container recycle quiclky. If azure dns is throttling
external-dns could never start and moreover worsen the situation .I want to review this piece of code to review where/how to implement retry ( in another pr).

[szuecs]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[szuecs]

Retry should be done by the library itself, at least AWS does it automatically and I would expect azure to do the same but if not it makes sense to invest into a retry.

[mloiseleur]

/retest

[szuecs]

--- FAIL: TestCoreDNSApplyChanges (0.00s)

I saw this in another PR

[pascalgn]

I created #4240 to consolidate discussions of TestCoreDNSApplyChanges test failure

[szuecs]

/test pull-external-dns-unit-test

[szuecs]

please rebase the test was fixed

[szuecs]

/lgtm