Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aws.go for issue #3833 #3834

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Update aws.go for issue #3833 #3834

merged 3 commits into from
Sep 1, 2023

Conversation

shreyas-3
Copy link
Contributor

Fix to add ap-south-2 region to support elb and nlb

Description

Updated aws.go file for new region ap-south-2 . Added zone id for classic/application load balancer and Network load balancer

Fixes #ISSUE
#3833

Checklist

  • Unit tests updated
  • End user documentation updated

@shreyas-3
Update aws.go for issue kubernetes-sigs#3833
f7ed26e 
Fix to add ap-south-2 region to support elb and nlb
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 1, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 1, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @shreyas-3!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @shreyas-3. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2023
@Raffo
Copy link
Contributor

Raffo commented Aug 5, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2023
Raffo
Raffo reviewed Aug 6, 2023
View reviewed changes
provider/aws/aws.go Outdated Show resolved Hide resolved
provider/aws/aws.go Outdated Show resolved Hide resolved
shreyas-3 and others added 2 commits August 7, 2023 10:07
@shreyas-3 @Raffo
Update provider/aws/aws.go
deb4f71 
Added missing quotes

Co-authored-by: Raffaele Di Fazio <[email protected]>
@shreyas-3 @Raffo
Update provider/aws/aws.go
a4d86b1 
Added missing quotes

Co-authored-by: Raffaele Di Fazio <[email protected]>
@johngmyers
Copy link
Contributor

@shreyas-3 Please sign the CLA and authorize your account as instructed in the comment by @linux-foundation-easycla above. We will not be able to accept your contribution until you do.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 9, 2023
@shreyas-3
Copy link
Contributor Author

shreyas-3 commented Aug 9, 2023 •
edited
Loading

@johngmyers I have signed CLA as individual contributor.

@johngmyers
Copy link
Contributor

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 9, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@mloiseleur
Copy link
Contributor

/lgtm

@Raffo
Copy link
Contributor

Raffo commented Sep 1, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, shreyas-3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit c70e5f8 into kubernetes-sigs:master Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raffo Raffo Raffo left review comments

@johngmyers johngmyers Awaiting requested review from johngmyers

@njuettner njuettner Awaiting requested review from njuettner

Assignees

@johngmyers johngmyers

@mloiseleur mloiseleur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shreyas-3 @k8s-ci-robot @Raffo @johngmyers @mloiseleur