Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Adjust TTL for alias records #3738

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

Sewci0
Copy link
Contributor

@Sewci0 Sewci0 commented Jun 27, 2023

When using CNAME record with a TTL != 0, external-dns will continuously keepUPSERTING the record due to a difference in TTL. As per https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/resource-record-sets-choosing-alias-non-alias.html TTL for alias records is always set to the default value of 300s and can not be modified.

Steps to reproduce:

  1. Create a CRD
apiVersion: externaldns.k8s.io/v1alpha1
kind: DNSEndpoint
metadata:
  name: test-example
spec:
  endpoints:
  - dnsName: test.example.com
    recordTTL: 60
    recordType: CNAME
    targets:
    - <ELB_TARGET>
  1. Wait for the record to be created
  2. Restart external-dns to invalidate caches.
  3. Desired change: UPSERT test.example.com

Checklist

  • Unit tests updated

@k8s-ci-robot k8s-ci-robot requested a review from johngmyers June 27, 2023 15:37
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2023
@k8s-ci-robot k8s-ci-robot requested a review from szuecs June 27, 2023 15:37
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2023
provider/aws/aws_test.go Outdated Show resolved Hide resolved
provider/aws/aws.go Show resolved Hide resolved
Co-authored-by: John Gardiner Myers <[email protected]>
@Sewci0 Sewci0 force-pushed the adjust-aws-alias-ttl branch 2 times, most recently from 86bb4f7 to fb85c0a Compare June 27, 2023 16:44
provider/aws/aws.go Outdated Show resolved Hide resolved
@Sewci0 Sewci0 force-pushed the adjust-aws-alias-ttl branch from fb85c0a to 7dfa6c5 Compare June 27, 2023 16:49
@Sewci0 Sewci0 force-pushed the adjust-aws-alias-ttl branch from 7dfa6c5 to 0019d15 Compare June 27, 2023 16:50
@johngmyers
Copy link
Contributor

Thanks!
/lgtm
/assign @seanmalloy

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2023
@szuecs
Copy link
Contributor

szuecs commented Jun 27, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 27, 2023
@johngmyers
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2023
@szuecs
Copy link
Contributor

szuecs commented Jun 28, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sewci0, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit e602e04 into kubernetes-sigs:master Jun 28, 2023
@johngmyers johngmyers mentioned this pull request Sep 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants