-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Adjust TTL for alias records #3738
Merged
k8s-ci-robot
merged 4 commits into
kubernetes-sigs:master
from
Sewci0:adjust-aws-alias-ttl
Jun 28, 2023
Merged
[AWS] Adjust TTL for alias records #3738
k8s-ci-robot
merged 4 commits into
kubernetes-sigs:master
from
Sewci0:adjust-aws-alias-ttl
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Jun 27, 2023
k8s-ci-robot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Jun 27, 2023
johngmyers
reviewed
Jun 27, 2023
Co-authored-by: John Gardiner Myers <[email protected]>
Sewci0
force-pushed
the
adjust-aws-alias-ttl
branch
2 times, most recently
from
June 27, 2023 16:44
86bb4f7
to
fb85c0a
Compare
johngmyers
reviewed
Jun 27, 2023
Sewci0
force-pushed
the
adjust-aws-alias-ttl
branch
from
June 27, 2023 16:49
fb85c0a
to
7dfa6c5
Compare
Sewci0
force-pushed
the
adjust-aws-alias-ttl
branch
from
June 27, 2023 16:50
7dfa6c5
to
0019d15
Compare
Thanks! |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jun 27, 2023
k8s-ci-robot
removed
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jun 27, 2023
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
label
Jun 27, 2023
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jun 27, 2023
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sewci0, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
ok-to-test
Indicates a non-member PR verified by an org member that is safe to test.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using CNAME record with a TTL != 0, external-dns will continuously keep
UPSERTING
the record due to a difference in TTL. As per https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/resource-record-sets-choosing-alias-non-alias.html TTL for alias records is always set to the default value of 300s and can not be modified.Steps to reproduce:
external-dns
to invalidate caches.Desired change: UPSERT test.example.com
Checklist