Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify filter interfaces #3660

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Simplify filter interfaces #3660

merged 2 commits into from
Jun 10, 2023

Conversation

johngmyers
Copy link
Contributor

Description

Refactor the two filtering interfaces to reduce complexity.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from seanmalloy and szuecs June 5, 2023 20:17
@johngmyers johngmyers mentioned this pull request Jun 6, 2023
Merged
@szuecs
Copy link
Contributor

szuecs commented Jun 8, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, mloiseleur, piotrkpc, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@szuecs
Copy link
Contributor

szuecs commented Jun 9, 2023

@johngmyers can you try to do /lgtm yourself?

@johngmyers
Copy link
Contributor Author

One can't LGTM one's own PR
/lgtm

@k8s-ci-robot
Copy link
Contributor

@johngmyers: you cannot LGTM your own PR.

In response to this:

One can't LGTM one's own PR
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@szuecs
Copy link
Contributor

szuecs commented Jun 9, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 9, 2023
@Raffo
Copy link
Contributor

Raffo commented Jun 10, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit b3885c3 into kubernetes-sigs:master Jun 10, 2023
@johngmyers johngmyers deleted the domainfilter branch June 10, 2023 10:46
@mloiseleur mloiseleur mentioned this pull request Jun 16, 2023
Closed
9 tasks
@johngmyers johngmyers mentioned this pull request Sep 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

@piotrkpc piotrkpc piotrkpc approved these changes

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@johngmyers @szuecs @k8s-ci-robot @Raffo @piotrkpc @mloiseleur