Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define Labels type and JSON tags for ProviderSpecific fields #3456

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Define Labels type and JSON tags for ProviderSpecific fields #3456

merged 1 commit into from
Jun 9, 2023

Conversation

aruneshpa
Copy link
Contributor

@aruneshpa aruneshpa commented Mar 6, 2023 •
edited
Loading

Description
The current example of CRD source is missing the Labels type
definition. It also does not have the JSON tag for the Name and
Value fields of the ProviderSpecificProperty type. As such,
creating a CRD from these types will result in errors.

This change fixes the two issues highlighted above.

Fixes #3455

Checklist

  • Unit tests updated
  • End user documentation updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 6, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: aruneshpa / name: Arunesh Pandey (21fce69)

@k8s-ci-robot
Copy link
Contributor

Welcome @aruneshpa!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 6, 2023
@aruneshpa
Define Labels type and JSON tags for ProviderSpecific fields
b2eebec 
The current example of CRD source is missing the `Labels` type
definition.  It also does not have the JSON tag for the `Name` and
`Value` fields of the `ProviderSpecificProperty` type.  As such,
creating a CRD from these types will result in errors.

This change fixes the two issues highlighted above.
@aruneshpa aruneshpa changed the title Include definition for Labels type in the readme Define Labels type and JSON tags for ProviderSpecific fields Mar 6, 2023
@aruneshpa
Copy link
Contributor Author

@seanmalloy, @szuecs Can one of you please review this? Thanks!

@szuecs
Copy link
Contributor

szuecs commented Jun 9, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aruneshpa, mloiseleur, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit ab11b2e into kubernetes-sigs:master Jun 9, 2023
@mloiseleur mloiseleur mentioned this pull request Jun 16, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@szuecs szuecs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for CRD source lacks the definition for Labels type
4 participants
@aruneshpa @k8s-ci-robot @szuecs @mloiseleur