-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): Added ability to customize the service account labels. #3074
Conversation
Welcome @jkroepke! |
@njuettner could you enable the workflow to run? |
@Raffo could you enable the GH workflow to run on this as I'd like to get it in for the v0.13.1 Helm chart release. |
@stevehipwell approved to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Jan-Otto Kröpke <[email protected]>
@stevehipwell Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkroepke, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Raffo could you re-approve the GH workflow and LGTM once it passes? Once this has been merged I'll create the next Helm chart release PR. |
@Raffo @njuettner @seanmalloy could someone approve the GH actions workflows and LGTM? |
I think the CI issue should be fixed by #3120. |
@jkroepke did you intentionally close this? |
@stevehipwell no. I delete and re-create the fork of external-dns while I forgot this outstanding PR. Sorry! |
@jkroepke could you rebase this to pickup the GH actions update? |
Signed-off-by: Jan-Otto Kröpke [email protected]
Description
Added ability to customise the service account labels.
AKS Workload Identity requires labels on service accounts.
Checklist