Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Added ability to customize the service account labels. #3074

Closed
wants to merge 1 commit into from
Closed

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Oct 9, 2022

Signed-off-by: Jan-Otto Kröpke [email protected]

Description

Added ability to customise the service account labels.

AKS Workload Identity requires labels on service accounts.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @jkroepke!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 9, 2022
@stevehipwell
Copy link
Contributor

@njuettner could you enable the workflow to run?

@stevehipwell
Copy link
Contributor

@Raffo could you enable the GH workflow to run on this as I'd like to get it in for the v0.13.1 Helm chart release.

@Raffo
Copy link
Contributor

Raffo commented Oct 22, 2022

@stevehipwell approved to run

@jkroepke jkroepke changed the title feat(chart): Added ability to customise the service account labels. feat(chart): Added ability to customize the service account labels. Oct 22, 2022
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkroepke could you remove your changes to Chart.yaml as these changes will be released as part of #3101.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2022
@jkroepke jkroepke requested review from stevehipwell and removed request for njuettner October 24, 2022 18:26
@jkroepke
Copy link
Contributor Author

@stevehipwell Done

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkroepke, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@stevehipwell
Copy link
Contributor

@Raffo could you re-approve the GH workflow and LGTM once it passes? Once this has been merged I'll create the next Helm chart release PR.

@stevehipwell
Copy link
Contributor

@Raffo @njuettner @seanmalloy could someone approve the GH actions workflows and LGTM?

@stevehipwell
Copy link
Contributor

I think the CI issue should be fixed by #3120.

@jkroepke jkroepke closed this by deleting the head repository Nov 9, 2022
@stevehipwell
Copy link
Contributor

@jkroepke did you intentionally close this?

@jkroepke
Copy link
Contributor Author

jkroepke commented Nov 9, 2022

@stevehipwell no. I delete and re-create the fork of external-dns while I forgot this outstanding PR. Sorry!

@jkroepke jkroepke reopened this Nov 9, 2022
@stevehipwell
Copy link
Contributor

@jkroepke could you rebase this to pickup the GH actions update?

@jkroepke
Copy link
Contributor Author

jkroepke commented Nov 9, 2022

@jkroepke could you rebase this to pickup the GH actions update?

Seems like new commits on fork branch not reflected here. I create a new one.

superseded by #3145

@jkroepke jkroepke closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants