Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headless service: allow to specify target as NodeExternalIP or by annotation #2115

Conversation

alfredkrohmer
Copy link
Contributor

Description

If external-dns.alpha.kubernetes.io/target annotation is present on a
pod, it's value will be used as the target for the headless service.

If annotation external-dns.alpha.kubernetes.io/access=public is present,
NodeExternalIP of the node running the pod is used as the target for the
headless service.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2021
@k8s-ci-robot k8s-ci-robot requested review from Raffo and seanmalloy May 31, 2021 15:59
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 31, 2021
@seanmalloy
Copy link
Member

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 1, 2021
@benesch
Copy link

benesch commented Jul 1, 2021

This would be super useful to us at @MaterializeInc! Any chance this could be reviewed and merged?

@alex-hunt-materialize
Copy link

Any update on this? We've been using a fork with this change and it's been working great.
https://github.com/MaterializeInc/external-dns

@robert-heinzmann-logmein

Any updates on this PR ?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2021
@alex-hunt-materialize
Copy link

/remove-lifecycle stale

Any update on this? It works great for us. We'd really like to point back at the upstream.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2021
@alex-hunt-materialize
Copy link

Bump. We've had no issues with our fork containing this PR after running it in production for months. We'd really love to point back at upstream, but we can't until this is merged.

@alex-hunt-materialize
Copy link

Bump. We'd love to get this merged so we can stop using a fork.

@Raffo
Copy link
Contributor

Raffo commented Mar 30, 2022

/check-cla

@Raffo Raffo closed this Mar 30, 2022
@Raffo Raffo reopened this Mar 30, 2022
source/service.go Outdated Show resolved Hide resolved
source/service.go Outdated Show resolved Hide resolved
docs/tutorials/hostport.md Outdated Show resolved Hide resolved
@alfredkrohmer alfredkrohmer force-pushed the feature/headless-service-nodeexternalip-targetannotation branch from 30608f8 to 7710630 Compare April 5, 2022 14:09
@Raffo
Copy link
Contributor

Raffo commented Apr 27, 2022

@alfredkrohmer you need to merge master in your branch to make sure the build passes.

…otation

If external-dns.alpha.kubernetes.io/target annotation is present on a
pod, it's value will be used as the target for the headless service.

If annotation external-dns.alpha.kubernetes.io/access=public is present,
NodeExternalIP of the node running the pod is used as the target for the
headless service.
@alfredkrohmer alfredkrohmer force-pushed the feature/headless-service-nodeexternalip-targetannotation branch from 7710630 to ea45b03 Compare May 5, 2022 17:44
@alfredkrohmer
Copy link
Contributor Author

@Raffo rebased from master

@Raffo
Copy link
Contributor

Raffo commented May 6, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alfredkrohmer, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3bca418 into kubernetes-sigs:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants