-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Headless service: allow to specify target as NodeExternalIP or by annotation #2115
Headless service: allow to specify target as NodeExternalIP or by annotation #2115
Conversation
/kind feature |
This would be super useful to us at @MaterializeInc! Any chance this could be reviewed and merged? |
Any update on this? We've been using a fork with this change and it's been working great. |
Any updates on this PR ? |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale Any update on this? It works great for us. We'd really like to point back at the upstream. |
Bump. We've had no issues with our fork containing this PR after running it in production for months. We'd really love to point back at upstream, but we can't until this is merged. |
Bump. We'd love to get this merged so we can stop using a fork. |
/check-cla |
30608f8
to
7710630
Compare
@alfredkrohmer you need to merge master in your branch to make sure the build passes. |
…otation If external-dns.alpha.kubernetes.io/target annotation is present on a pod, it's value will be used as the target for the headless service. If annotation external-dns.alpha.kubernetes.io/access=public is present, NodeExternalIP of the node running the pod is used as the target for the headless service.
7710630
to
ea45b03
Compare
@Raffo rebased from master |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alfredkrohmer, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
If external-dns.alpha.kubernetes.io/target annotation is present on a
pod, it's value will be used as the target for the headless service.
If annotation external-dns.alpha.kubernetes.io/access=public is present,
NodeExternalIP of the node running the pod is used as the target for the
headless service.
Checklist