-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to controller-gen for CRD generation and update CRD to apiextentions v1 #2001
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @k0da! |
Signed-off-by: Dinar Valeev <[email protected]>
v1 is available since kubernetes 1.16, since then v1beta1 is deprecated and will be dropped in kubernetes 1.22 Signed-off-by: Dinar Valeev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍🏻 , thanks for updating apiextension to v1, I'm fine merging it. This should work with >= v1.16.
/cc @Raffo
I'm fine with this change. |
/assign @njuettner |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k0da, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sync DNSEndpoint CRD from upstream where it was updated to apiextentions.k8s.io/v1 kubernetes-sigs/external-dns#2001 Signed-off-by: Dinar Valeev <[email protected]>
Sync DNSEndpoint CRD from upstream where it was updated to apiextentions.k8s.io/v1 kubernetes-sigs/external-dns#2001 Signed-off-by: Dinar Valeev <[email protected]>
Sync DNSEndpoint CRD from upstream where it was updated to apiextentions.k8s.io/v1 kubernetes-sigs/external-dns#2001 Signed-off-by: Dinar Valeev <[email protected]>
Description
Fixes #2000
Checklist