Skip to content

Commit

Permalink
Webhook provider helm chart fixes
Browse files Browse the repository at this point in the history
- Add webhook resources values to deployment
- Correct webhook containers metric port in servicemonitor
- Use correct imagePullPolicy value for webhook container
  • Loading branch information
kimsondrup committed Jul 30, 2024
1 parent 4da484b commit caa8373
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion charts/external-dns/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ spec:
{{- with .Values.provider.webhook }}
- name: webhook
image: {{ include "external-dns.webhookImage" . }}
imagePullPolicy: {{ $.Values.image.pullPolicy }}
imagePullPolicy: {{ .image.pullPolicy }}
{{- with .env }}
env:
{{- toYaml . | nindent 12 }}
Expand Down Expand Up @@ -177,6 +177,10 @@ spec:
securityContext:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .resources }}
resources:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- end }}
{{- end }}
{{- if or .Values.secretConfiguration.enabled .Values.extraVolumes }}
Expand Down
2 changes: 1 addition & 1 deletion charts/external-dns/templates/servicemonitor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
{{- end }}
{{- if eq $providerName "webhook" }}
{{- with .Values.provider.webhook.serviceMonitor }}
- port: webhook-metrics
- port: http-wh-metrics
path: /metrics
{{- with .interval }}
interval: {{ . }}
Expand Down

0 comments on commit caa8373

Please sign in to comment.