Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable issue and pr templates #298

Merged
merged 1 commit into from
Jul 26, 2023
Merged

enable issue and pr templates #298

merged 1 commit into from
Jul 26, 2023

Conversation

harshanarayana
Copy link
Contributor

Closes #295

@k8s-ci-robot k8s-ci-robot requested a review from cpanato July 15, 2023 19:14
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshanarayana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2023
@harshanarayana
Copy link
Contributor Author

@cpanato @vladimirvivien How do I quickly verify these templates look right and render properly without having to merge it first ?

@harshanarayana harshanarayana force-pushed the feature/enable-issue-tempaltes branch from a11718b to a3d5a77 Compare July 17, 2023 12:03
@phisco
Copy link
Contributor

phisco commented Jul 17, 2023

@harshanarayana, FYI: I usually enable issues on my fork and merge them on main there

@harshanarayana
Copy link
Contributor Author

@phisco I created a dummy repo and tested this out. 😄

@jbpratt
Copy link
Contributor

jbpratt commented Jul 26, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit c5714bb into kubernetes-sigs:main Jul 26, 2023
@harshanarayana harshanarayana mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@ShwethaKumbla ShwethaKumbla Awaiting requested review from ShwethaKumbla

Assignees

@jbpratt jbpratt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue template
4 participants
@harshanarayana @k8s-ci-robot @phisco @jbpratt