Updates for dependabot and ci job #225
Conversation
k8s-ci-robot
added
the
sig/testing
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
the
approved
|
/test pull-e2e-framework-test |
Signed-off-by: cpanato <[email protected]>
Signed-off-by: cpanato <[email protected]>
k8s-ci-robot
removed
the
lgtm
| @@ -14,20 +14,21 @@ jobs: | |||
|
|
|||
| steps: | |||
| - name: Checkout | |||
| uses: actions/checkout@v2 | |||
| uses: actions/checkout@24cb9080177205b6e8c946b17badbe402adc938f # v3.4.0 | |||
There was a problem hiding this comment.
Hi @cpanato ! Curious why the hash instead of the the tag?
There was a problem hiding this comment.
it is a best practice to use the hash instead of the tag, the tag is mutable and can be changed, but the hash not :)
and we pin to a specific release. also dependabot can update that and also update the version comment :)
hope that clarifies
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, ShwethaKumbla, vladimirvivien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vladimirvivien i will try to check later why the test is failing, i saw this in other PRs |
|
@cpanato I saw that too. I plan to check it out as well. Thanks. |
|
@vladimirvivien @cpanato I noticed the same too. it seems to be the same set of test that are failing since March 25th. I am checking locally to see what might be causing it |
fix here: #229 |
|
/retest |
/assign @vladimirvivien