-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update Document organization structure #206
docs: Update Document organization structure #206
Conversation
@vladimirvivien to help discuss the re-grouping of Examples document, I have done it for two files. Wonder what would be the best way to org them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshanarayana apologies for the late reply.
I think you are on the right track.
I don't think you need to move the markdown docs from the examples
directory.
For now, you can just copy them into the docs
directory as to keep the examples complete.
You mean keep two copies of it ? |
@harshanarayana or keep a README.md in examples that links to where the respective example is documented. That way, if I browse from example directory I can get back to documentation about example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d51bdd3
to
44f4c6b
Compare
I thought I can do this easily and created a few symlinks. Seems like github won't redirect you to the symlink location if you click on the file :( It just show the path for which the current file links to. (The changes are pushed to the branch for now, I will revert them. Leaving them for now just to show you what it looks like.) Shall I add a section on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harshanarayana
Apologies for the late reply.
I have added a comment. I think it's almost there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshanarayana Hi 👋
Please add a table of content here that links to the different sections. That way, when a user clicks on docks directory, the list of available content will be displayed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack. Pushing the changes now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshanarayana I have one question. Other than that, I think this is ready to go.
docs/README.md
Outdated
- [Multi Cluster Tests](#multi-cluster-tests) | ||
- [Third Party Integration](#third-party-integration) | ||
|
||
|
||
# Go E2E Test Framework for Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harshanarayana this line seems to have moved to line 13. I think It is the title and should be at the top, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/Ack. You are right. Let me re order that bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. PTAL when possible @vladimirvivien
docs: enable TOC for easy navigation docs: enable TOC for easy navigation
5b7e91c
to
17d3b02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @harshanarayana
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshanarayana, vladimirvivien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #192
Discussion Items