-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document -skip flag in go test #204
Document -skip flag in go test #204
Conversation
Welcome @reetasingh! |
Hi @reetasingh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/ok-to-test
/assign @vladimirvivien
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reetasingh Thank you for your contribution. This is a good start. Can you also add an example that shows using both the new -skip
flag and existing e2e-framework --skip-xxx
flags? That way readers can see that they are different and impact the tests differently.
@reetasingh @vladimirvivien @cpanato Should we also not document what happens to the frameworks Setup and teardown handlers when used in conjunction with |
972b1ba
to
032076c
Compare
Hi @vladimirvivien I have added some examples |
Hi @harshanarayana by this you mean what happens when we skip the TestMain itself? Looks like that is not possibel
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks!
I think the doc is in a good place now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshanarayana, reetasingh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vladimirvivien adding an LGTM from my end. |
Fixes #200
Go 1.20 introduces the
-skip
flag forgo test
command to skip tests.Document how to use this flag in examples/skip_flags