Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update k8s dependencies to v1.24.1 #142

Merged
merged 1 commit into from
Jun 9, 2022
Merged

update k8s dependencies to v1.24.1 #142

merged 1 commit into from
Jun 9, 2022

Conversation

harshanarayana
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @harshanarayana. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from cpanato June 5, 2022 16:34
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 5, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 5, 2022
@harshanarayana
Copy link
Contributor Author

/cc @vladimirvivien

@ShwethaKumbla
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2022
@harshanarayana
Copy link
Contributor Author

/hold Creating a PR on the test-infra for this first.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@harshanarayana harshanarayana mentioned this pull request Jun 7, 2022
Merged
vladimirvivien
vladimirvivien approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 7, 2022
@harshanarayana
Copy link
Contributor Author

/retest

@harshanarayana
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@harshanarayana
Copy link
Contributor Author

/retest

@harshanarayana
Copy link
Contributor Author

@vladimirvivien @cpanato Looks like the verify job is timing out after updating the go version on the test-infra repo. Do I need any other PR on other repo for this ?

@harshanarayana
Copy link
Contributor Author

kubernetes/test-infra#26534 Fixing the broken Image from my previous image. Sorry from breaking this! I should have looked a bit more carefully.

@harshanarayana
Copy link
Contributor Author

/retest

1 similar comment
@harshanarayana
Copy link
Contributor Author

/retest

@harshanarayana harshanarayana force-pushed the dep/update-k8s-version branch from 1d7cfea to 03e0588 Compare June 8, 2022 18:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2022
harshanarayana
harshanarayana commented Jun 8, 2022
View reviewed changes
hack/verify-golangci-lint.sh
@@ -18,7 +18,7 @@ set -o errexit
set -o nounset
set -o pipefail

VERSION=v1.44.0
VERSION=v1.46.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to bump this up due to golangci/golangci-lint#2374

@harshanarayana
Copy link
Contributor Author

@vladimirvivien Need a LGTM again. I updated the version of golangci-lint to account for go1.18

ShwethaKumbla
ShwethaKumbla approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@ShwethaKumbla ShwethaKumbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshanarayana, ShwethaKumbla, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ShwethaKumbla,vladimirvivien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e93ce38 into kubernetes-sigs:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirvivien vladimirvivien vladimirvivien approved these changes

@ShwethaKumbla ShwethaKumbla ShwethaKumbla approved these changes

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@vladimirvivien vladimirvivien

@ShwethaKumbla ShwethaKumbla

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshanarayana @k8s-ci-robot @ShwethaKumbla @vladimirvivien