Add crictl [create,runp,run,pull] jsonschema subcommands
#1449
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
approved
saschagrunert
force-pushed
the
json-schema
branch
2 times, most recently
from
79ef7af to
63e11d5
Compare
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
k8s-ci-robot
added
the
needs-rebase
saschagrunert
force-pushed
the
json-schema
branch
from
63e11d5 to
89ca668
Compare
k8s-ci-robot
removed
the
needs-rebase
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
cmd/crictl/image.go
Outdated
| Subcommands: []*cli.Command{{ | ||
| Name: "jsonschema", | ||
| Aliases: []string{"js"}, | ||
| Usage: "Display the JSON schema for the pod-config.json", |
There was a problem hiding this comment.
why this for the image subcommand?
There was a problem hiding this comment.
pedantically: seems like a bleeding of the runtime service into the image client (not like they're actually separated in practice)
There was a problem hiding this comment.
It's added here because of crictl pull --pod-config pod-config.[json|yam].
There was a problem hiding this comment.
I am not sure I understand the logic of using it in pull. What is the output of a command will be?
There was a problem hiding this comment.
@SergeyKanzhelev the sandbox config provides additional context during the image pull. For example CRI-O uses it to separate pulls into dedicated cgroups:
k8s-ci-robot
added
the
needs-rebase
saschagrunert
force-pushed
the
json-schema
branch
from
89ca668 to
43e7d85
Compare
k8s-ci-robot
removed
the
needs-rebase
saschagrunert
force-pushed
the
json-schema
branch
from
43e7d85 to
1bedd5e
Compare
The `jsonschema` / `js` subcommands will print the pod and/or container config JSON schemas for end users to understand where the data is coming from. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
json-schema
branch
from
1bedd5e to
cd11136
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
What type of PR is this?
/kind feature
What this PR does / why we need it:
The
jsonschema/jssubcommands will print the pod and/or container config JSON schemas for end users to understand where the data is coming from.Which issue(s) this PR fixes:
Refers to kubernetes/website#40360
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?