Fix seccomp value in test #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/regression
k8s-ci-robot
added
approved
saschagrunert
force-pushed
the
seccomp-filter
branch
3 times, most recently
from
bed9a6b to
4c46c79
Compare
saschagrunert
added a commit
to saschagrunert/kubernetes
that referenced
this pull request
Aug 10, 2023
The tests have been introduced in kubernetes@ca7be7d and checked for `ecc` in `/proc/self/status` since its creation. We got a new field `Seccomp_filters:` with the Linux commit torvalds/linux@c818c03, means that `ecc` would now match both and interfere with possible test results depending on the host. The field `Seccomp:` got introduced in torvalds/linux@2f4b3bf and has never changed since then, means we can use it directly to make the tests more strict. Refers to kubernetes-sigs/cri-tools#1236 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
seccomp-filter
branch
from
4c46c79 to
1280326
Compare
k8s-ci-robot
added
size/S
The seccomp value should be `2` rather than `1`. The test succeeded because we also have the value `Seccomp_filters` which gets matched by "ecc", too. We now check for "Seccomp:" to actually match the right field. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
seccomp-filter
branch
from
1280326 to
26d35da
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind regression
What this PR does / why we need it:
The seccomp value should be
2rather than1. The test succeeded because we also have the valueSeccomp_filterswhich gets matched by "ecc", too. We now check for "Seccomp:" to actually match the right field.Which issue(s) this PR fixes:
Refers to https://github.com/kubernetes-sigs/cri-tools/pull/1181/files#r1288562050
Special notes for your reviewer:
The field was always
Seccomp:since torvalds/linux@2f4b3bf and has never changed.The
Seccomp_filters:field has been added in torvalds/linux@c818c03Does this PR introduce a user-facing change?