Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default timeout on Windows #1058

Merged

Conversation

jsturtevant
Copy link
Contributor

Signed-off-by: James Sturtevant [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Most interactions against Windows containers take longer than 2s. This increases the default so the user experience on Windows is better without having to modify every command or know to create a config file with the timeout.

When creating the first pod it can take a long time to pull due to image container sizes so the timeout here is very high to handle this scenario. Starting a Pod can take longer than 2s even when the image is already pulled.

Which issue(s) this PR fixes:

Special notes for your reviewer:

/cc @dcantah @marosset
/sig windows

Does this PR introduce a user-facing change?

Increase default timeout to 200s when running on Windows 

Signed-off-by: James Sturtevant <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2023
@dcantah
Copy link
Member

dcantah commented Jan 6, 2023

200s is just to account for the first pull of the pause image on RunPodSandbox I assume?

@dcantah
Copy link
Member

dcantah commented Jan 6, 2023

Ahh, it's in the description

Copy link
Member

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine.. although perhaps a comment above the timeout stating the reasoning for the discrepancy between linux and win

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2023
@marosset
Copy link

marosset commented Jan 6, 2023

I'd also like to add that if you forget to increase the timeout when creating a new pod or starting a container on Windows if the operation times out it is very tedious to try and clean up the failed operation.
This has personally caused me some frustration in the past.

Copy link

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@marosset
Copy link

marosset commented Jan 6, 2023

/sig windows

@dcantah
Copy link
Member

dcantah commented Jan 6, 2023

I'd also like to add that if you forget to increase the timeout when creating a new pod or starting a container on Windows if the operation times out it is very tedious to try and clean up the failed operation.

This has personally caused me some frustration in the past.

In what way? Was this the "doesn't have {insert specific metadata field}" error we'd ran into before when testing things via crictl? I'd think that'd also hold true for Linux. I just remember crictl rm not functioning because it whined we didn't fill in every field, but nothing Windows specific

@marosset
Copy link

marosset commented Jan 6, 2023

e "doesn't have {insert specific metadata field}" error we'd ran in

Yes it was that error. It may hold true for Linux but I have never encountered the issue on Linux w/ the default timeout :P

@dcantah
Copy link
Member

dcantah commented Jan 6, 2023

Fair enough LOL

@haircommander
Copy link
Contributor

/lgtm

@saschagrunert PTAL

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcantah, feiskyer, jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 18e5983 into kubernetes-sigs:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants