-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase default timeout on Windows #1058
Increase default timeout on Windows #1058
Conversation
Signed-off-by: James Sturtevant <[email protected]>
200s is just to account for the first pull of the pause image on RunPodSandbox I assume? |
Ahh, it's in the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine.. although perhaps a comment above the timeout stating the reasoning for the discrepancy between linux and win
I'd also like to add that if you forget to increase the timeout when creating a new pod or starting a container on Windows if the operation times out it is very tedious to try and clean up the failed operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/sig windows |
In what way? Was this the "doesn't have {insert specific metadata field}" error we'd ran into before when testing things via crictl? I'd think that'd also hold true for Linux. I just remember crictl rm not functioning because it whined we didn't fill in every field, but nothing Windows specific |
Yes it was that error. It may hold true for Linux but I have never encountered the issue on Linux w/ the default timeout :P |
Fair enough LOL |
/lgtm @saschagrunert PTAL |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcantah, feiskyer, jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: James Sturtevant [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
Most interactions against Windows containers take longer than 2s. This increases the default so the user experience on Windows is better without having to modify every command or know to create a config file with the timeout.
When creating the first pod it can take a long time to pull due to image container sizes so the timeout here is very high to handle this scenario. Starting a Pod can take longer than 2s even when the image is already pulled.
Which issue(s) this PR fixes:
Special notes for your reviewer:
/cc @dcantah @marosset
/sig windows
Does this PR introduce a user-facing change?