Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Revert "✨ Remove status from generated CRDs" #472

Merged

Conversation

mcristina422
Copy link
Contributor

Reverts #433

In #433 I attempted to drop the entire status block from generated CRDs for tools like ArgoCD. I wrongly assumed that the omitempty marker on the CRD status field made it so the status field would not be generated at all. This is not true due to it not being a pointer, causing it always to be generated. We will need to manually set these still to pass validation

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 17, 2020
@mcristina422
Copy link
Contributor Author

@vincepri @alvaroaleman @DirectXMan12 @mengqiy I think this should be merged as it's actually causing incorrect CRDs to be generated on master now #456

I made a mistake in my previous commit when updating the testdata additioanlly. I thought that I had to manually update the generated output to the desired output and that's what I used in my tests. I understand now that that's not how that is tested or validated in CI

@vincepri
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mcristina422, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 56de576 into kubernetes-sigs:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants